From owner-freebsd-usb@FreeBSD.ORG Sun Jan 12 08:10:01 2014 Return-Path: Delivered-To: freebsd-usb@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9FE26E45 for ; Sun, 12 Jan 2014 08:10:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6EC391E6B for ; Sun, 12 Jan 2014 08:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0C8A1h8003361 for ; Sun, 12 Jan 2014 08:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0C8A1lr003360; Sun, 12 Jan 2014 08:10:01 GMT (envelope-from gnats) Date: Sun, 12 Jan 2014 08:10:01 GMT Message-Id: <201401120810.s0C8A1lr003360@freefall.freebsd.org> To: freebsd-usb@FreeBSD.org Cc: From: Hans Petter Selasky Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Hans Petter Selasky List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jan 2014 08:10:01 -0000 The following reply was made to PR usb/185628; it has been noted by GNATS. From: Hans Petter Selasky To: Alex Goncharov , freebsd-usb@FreeBSD.org, freebsd-gnats-submit@freebsd.org Cc: Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321 Date: Sun, 12 Jan 2014 09:08:27 +0100 On 01/12/14 07:10, Alex Goncharov wrote: > The following reply was made to PR usb/185628; it has been noted by GNATS. > > From: Alex Goncharov > To: "freebsd-gnats-submit@FreeBSD.org" , > Hans Petter Selasky , freebsd-usb@FreeBSD.org > Cc: > Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321 > Date: Sat, 11 Jan 2014 21:58:02 -0800 (PST) > > --2120775178-1643984294-1389506282=:33519 > Content-Type: text/plain; charset=us-ascii > > ,-- On Fri, 1/10/14, Hans Petter Selasky wrote: > ,-- On 01/10/14 12:49, Alex Goncharov wrote: > >> Maybe; but think about the fact correlations: the fact of the two > >> system's upgrade, two identical Seagate units, and other HDDs being > >> non-stalled. > > > > If you are running EHCI, there has been no changes in the USB stack, > > Apparently, there have been; this is what causes the bogus error: > > ------------------------------------------------------------------------ > r259454 | hselasky | 2013-12-16 03:51:58 -0500 (Mon, 16 Dec 2013) | 11 lines > > MFC r244503 and r246565: > > Make sure all USB drivers allocate buffer memory > through the USB API and/or busdma. > > The following assumptions have been made: > umass - buffers passed from CAM/SCSI layer are OK > network - mbufs are OK. > > Some other nits while at it. > ------------------------------------------------------------------------ > > I am attaching the code difference for the two relevant files > > ---------------------------------------- > M sys/dev/usb/storage/ustorage_fs.c > M sys/dev/usb/usb_msctest.c > ---------------------------------------- > > in this change set, skipping the irrelevant 'sys/dev/usb/wlan' ones. > > Can this be fixed reasonably soon, please? (I miss my HDDs :) > Hi, Can you do "usbdump -i usbusX -s 65536 -vvv" where is X is the controller unit which the seagate drive attaches to, before and after reverting patch "259454". I need to see what the difference is in the USB level, because patch "259454" should not affect the protocol data only the timing. --HPS