Date: Wed, 17 Nov 2004 15:30:26 GMT From: John Baldwin <jhb@FreeBSD.org> To: freebsd-usb@FreeBSD.org Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item Message-ID: <200411171530.iAHFUQBL029042@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/63837; it has been noted by GNATS. From: John Baldwin <jhb@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org, nivit@email.it Cc: Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item Date: Wed, 17 Nov 2004 09:59:20 -0500 So, I think that the first part of the patch (setting h.report_ID to zero) is not needed. Basically, AFAICT, the effect of the patch is that hid_report_size() will now return the ID of the first device of a given kind rather than the last such device. This seems to be a horrible interface fwiw, and while this hack might work, I think the real fix is to adopt some of the changes NetBSD made with their uhiddev. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411171530.iAHFUQBL029042>