From owner-freebsd-bugs  Sat Sep 29  5: 0: 8 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A285337B406
	for <freebsd-bugs@hub.freebsd.org>; Sat, 29 Sep 2001 05:00:03 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f8TC03B23801;
	Sat, 29 Sep 2001 05:00:03 -0700 (PDT)
	(envelope-from gnats)
Date: Sat, 29 Sep 2001 05:00:03 -0700 (PDT)
Message-Id: <200109291200.f8TC03B23801@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Ian Dowse <iedowse@maths.tcd.ie>
Subject: Re: bin/30863: bootpd/dovend.c Win95 compatibility improvement and typos in error messages 
Reply-To: Ian Dowse <iedowse@maths.tcd.ie>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/30863; it has been noted by GNATS.

From: Ian Dowse <iedowse@maths.tcd.ie>
To: Dan Lukes <dan@obluda.cz>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/30863: bootpd/dovend.c Win95 compatibility improvement and typos in error messages 
Date: Sat, 29 Sep 2001 12:59:19 +0100

 In message <200109270142.f8R1gEH43139@xkulesh.vol.cz>, Dan Lukes writes:
 >
 >	Win95 release ignore dn (domain-name) field unless <NUL> terminated.
 >Padding shouldn't cause a problem on other systems
 
 Hi,
 
 The ISC dhcpd only NUL-terminates replies when it detects a Microsoft
 client that requires it:
 
         /* Set a flag if this client is a lame Microsoft client that NUL
            terminates string options and expects us to do likewise. */
         if (packet -> options [DHO_HOST_NAME].data &&
             packet -> options [DHO_HOST_NAME].data
             [packet -> options [DHO_HOST_NAME].len - 1] == '\0')
                 lease -> flags |= MS_NULL_TERMINATION;
         else
                 lease -> flags &= ~MS_NULL_TERMINATION;
 
 How easy would it be to do something like this in our bootpd instead?
 ISC-dhcpd is much more actively developed and widely used than bootpd
 is, so it's probably better to try and follow dhcpd's approach where
 possible to avoid problems that they may have already solved.
 
 Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message