From owner-svn-src-projects@FreeBSD.ORG Thu May 5 16:30:02 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC8D5106564A; Thu, 5 May 2011 16:30:01 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 78DAF8FC15; Thu, 5 May 2011 16:30:01 +0000 (UTC) Received: by vxc34 with SMTP id 34so3327371vxc.13 for ; Thu, 05 May 2011 09:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=TlAp2NQkthntPyqXU957Q9Nio6cFUJzZMZezlcN7HAQ=; b=AIu/yT3dpIgQx4TEwsIdVnpxGk/RaI1JVeCwVPhEWJjzZftDJVlTFp4nLkNH5Ot4tM UnhY5n+52o6gm5xp1y+T2zB7RNrm8Q6DMghXyIHazdtNID1SBJ3iOy4DPje3kIgwMiag WwfOyu+0Q2ybxHPP+ZBUzZC0yRp/Ka0jtRcp4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=kC8OZUlqkG/AA8YEBc5NZB3Zml7qqdHHXgcId5DNo6Krvl4QaQSj/H8O15VGWFqlzG /6XO6TElrqnCagMSNaS4sCCuNTWlWoC0vHARddeE2Z4I0tmEHao0KLfxaovVAFJ6DAES H2QedZg7zuZQSjoYmkrXcRxwxOg0sUOK9Wk5I= MIME-Version: 1.0 Received: by 10.220.18.74 with SMTP id v10mr658885vca.62.1304611149874; Thu, 05 May 2011 08:59:09 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.220.201.3 with HTTP; Thu, 5 May 2011 08:59:09 -0700 (PDT) In-Reply-To: References: <201105051439.p45EdEgC003770@svn.freebsd.org> Date: Thu, 5 May 2011 11:59:09 -0400 X-Google-Sender-Auth: c7q6yuR67rhm0TKzrPN2IPRyyVw Message-ID: From: Attilio Rao To: mdf@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221499 - in projects/largeSMP: gnu/usr.bin/gdb/kgdb lib/libmemstat sys/amd64/acpica sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/cddl/dev/cyclic/i386 sys/cddl/dev/... X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 16:30:02 -0000 2011/5/5 : > On Thu, May 5, 2011 at 7:39 AM, Attilio Rao wrote: >> Author: attilio >> Date: Thu May =C2=A05 14:39:14 2011 >> New Revision: 221499 >> URL: http://svn.freebsd.org/changeset/base/221499 >> >> Log: >> =C2=A0Commit the support for removing cpumask_t and replacing it directl= y with >> =C2=A0cpuset_t objects. > > I suppose it's a bit of a bikeshed issue, but I found a few of the > names a little confusing. =C2=A0I'd prefer: > > s/CPU_OVERLAP/CPU_INTERSECT > s/CPU_NAND/CPU_CLRSET (to mirror CPU_CLR) or CPU_SUBTRACT or CPU_DIFFEREN= CE > > Possibly also s/CPU_OR/CPU_SETSET or CPU_UNION. =C2=A0In general I found > the naming a bit confusing since it seemed that, though these are > declared as a set of cpus (cpuset_t) the operation names aren't > set-type operations, like UNION, INTERSECT, DIFFERENCE, etc. > > It looks like the names have been around for a while, but I suspect > they don't see much use until this branch. I really don't want to mix style changes with functionality, maybe we can tweak names later, I'm not against it. Attilio --=20 Peace can only be achieved by understanding - A. Einstein