From nobody Wed Jun 28 20:47:31 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qrttr1d8nz4kbWy; Wed, 28 Jun 2023 20:47:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qrttr0mk4z3nvy; Wed, 28 Jun 2023 20:47:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687985252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pGihifo8G3tczpHhu1agT71+wxqbIiskyY9P0Fy2Rz8=; b=gkiprTwyqMIloXBj9AB9E0lfUtSJ9pq+cF9HY8oUPWMDRYDH3xkfc3SPFL3viWUK1U9O8D HVXrUMia2GzGhqY8yYGmL4WCMFk1frZiB+RMDFvCGyYn8FzuNFx/hss3L1aV92qET9IQyr RPgKcAYHyPTiUWFY6h6Yq1bEvMlZ0HqsF0GtQyFEB8QjPNKbF7H0R1a9eUYN+LHL8Ukmth B175jxPUYGBzSqzzq0BAJAxYzJSLLphJRPZ6xaIDutkk5B9e1kz3lUCVXfMO7npnriiT97 TLOw6KmyBHGdnAWigj3IIgguaJZlbUtWEOQGuG+NnX7OjaXp8xnC46z1vYnhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687985252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pGihifo8G3tczpHhu1agT71+wxqbIiskyY9P0Fy2Rz8=; b=IAUu2BixxrD6Lsg7OLruT+yDAIb0DCXukqlQetNL+aEGmJ4v4I0NcjdkG7q/2PNffU3JfF /Q9wJz4sc5kIcOjkKqK9KX2F5mRC2VrO7thRspUQQGKPbTDVYxzDLFYv65vM1KcPxasVLF 54BpFjIl34algHU39tq6hLh+lKjMZeGcx5FTUuu2pLouPYJihvzxkLKIyuKtkXKaVVBRP+ sWojXXi5ZuU9cDM2O9J47z5PEGMVFbrsI7cCY57XP4gGjQa2L5DWa1paETw7pFsKXiTuIw h6YMe3QLKNRxfEk3CpRmnWCnY6QexoULHw91smJZidRrrTpONaAgRhmMxkMIcA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687985252; a=rsa-sha256; cv=none; b=j2qDagr3GILhmyt19J+PMY5CLg8+4JacCcOcGs2cPyRElnrue+Y+ePPXQGvNdz8nUCs9MZ n3oyOkS0pPlZxxeDKGW5ZwSyjuXjU9g0mKFKLmfeocLatIoWp/UREcVAYmNRIy1zTN/1V9 lLZYsIA8abCvbPcHL5xdfi718mvRdncz4lE8gTJbNkjDEx3xdY/T2zR6MXDVwv9xf+JXsl CsG4yRyfiSrQDAQoHFq1zUkhlG4Y8iBkOsaatBvn1RkK0wW3CsbgpevucCHCxzHn//XiHL KwTbLSjxaxBheDMGYQeK603vpILUMj/hDk6sbNqb72d6SvRE3eT1EMoeie09Mg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qrttq6x0lznVv; Wed, 28 Jun 2023 20:47:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 35SKlVcA058471; Wed, 28 Jun 2023 20:47:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 35SKlV2G058470; Wed, 28 Jun 2023 20:47:31 GMT (envelope-from git) Date: Wed, 28 Jun 2023 20:47:31 GMT Message-Id: <202306282047.35SKlV2G058470@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 13013d266e77 - main - bhyve: Stop calling pci_lintr_request() in the NVMe device model List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13013d266e7781022fde04509670d0ce5f2ac25f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=13013d266e7781022fde04509670d0ce5f2ac25f commit 13013d266e7781022fde04509670d0ce5f2ac25f Author: Mark Johnston AuthorDate: 2023-06-28 20:06:21 +0000 Commit: Mark Johnston CommitDate: 2023-06-28 20:29:49 +0000 bhyve: Stop calling pci_lintr_request() in the NVMe device model The device model effectively assumes that MSI-X is enabled (it never asserts the legacy interrupt), so any guest which relies on being able to use the legacy PCI interrupt will fail. The WIP arm64 port does not implement legacy PCI interrupts, but NVMe emulation is potentially useful there. Simply remove the call. Reviewed by: corvink, chuck, jhb Tested by: chuck MFC after: 1 month Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D40731 --- usr.sbin/bhyve/pci_nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index a18413a50367..67153b4cd00f 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3312,8 +3312,6 @@ pci_nvme_init(struct pci_devinst *pi, nvlist_t *nvl) pci_nvme_reset(sc); - pci_lintr_request(pi); - done: return (error); }