From owner-svn-src-user@FreeBSD.ORG Sun Oct 21 22:47:12 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B1FF14B9 for ; Sun, 21 Oct 2012 22:47:12 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 111518FC0C for ; Sun, 21 Oct 2012 22:47:11 +0000 (UTC) Received: (qmail 55812 invoked from network); 22 Oct 2012 00:25:23 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 22 Oct 2012 00:25:23 -0000 Message-ID: <50847B60.3080108@freebsd.org> Date: Mon, 22 Oct 2012 00:46:56 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: attilio@FreeBSD.org Subject: Re: svn commit: r241805 - in user/andre/tcp_workqueue/sys: kern sys References: <201210211152.q9LBqGZc066660@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2012 22:47:12 -0000 On 21.10.2012 16:24, Attilio Rao wrote: > On Sun, Oct 21, 2012 at 12:52 PM, Andre Oppermann wrote: >> Author: andre >> Date: Sun Oct 21 11:52:16 2012 >> New Revision: 241805 >> URL: http://svn.freebsd.org/changeset/base/241805 >> >> Log: >> Add MTX_DEF_SYSINIT() macro which combines defining a global mutex >> with initializing it and ensuring the cache line alignment. > > If you really want such api (I'm not entirely sure i like it because > it could lead to less readability in my opinion), can I suggest that > you also unify the behaviour with other current kernel users? This way > we have at least a defined and clear policy (and also that you submit > it before to merge in -CURRENT the workqueue branch). See r241815 for first batch. :) -- Andre