Date: Mon, 17 Feb 2003 00:49:03 -0800 (PST) From: David Yeske <dyeske@yahoo.com> To: Kris Kennaway <kris@obsecurity.org> Cc: ports@freebsd.org, sobomax@FreeBSD.org, Mario <lioux@freebsd.org> Subject: Re: USE_SDL Message-ID: <20030217084903.80946.qmail@web13508.mail.yahoo.com> In-Reply-To: <20030217080104.GB70689@rot13.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm trying to follow the methods applied to GTK_CONFIG and GLIB_CONFIG, unless there is a better
way to do this. Most of the time the information provided by ${SDL_CONFIG} --libs does not need
to be redefined because most ports will or should use ${SDL_CONFIG} --libs to determine those
values. Sometimes -lSDL will be hardcoded but that is not common There is no GTK_LIBS or
GLIB_LIBS defined, and developers are responsible for knowing when to use `${GTK/GLIB_CONFIG}
--libs`. I think it would be appropriate to not define SDL_LIBS via USE_SDL.
$ grep -i sdl-1 /usr/ports/INDEX | wc -l
137
This would add consistency to over 130 ports which would result in less frequent modifications.
--- Kris Kennaway <kris@obsecurity.org> wrote:
> On Sun, Feb 16, 2003 at 10:03:43PM -0800, David Yeske wrote:
> > I wanted to get feedback on USE_SDL. Most sdl ports have to redefine things like sdl-config,
> > -lSDL, or SDL/SDL.h. Maybe USE_SDL in bsd.port.mk would save time, add consistency, and
> reduce
> > duplication. This is only an example, and it has not been tested well.
> >
> > .if defined(USE_SDL)
> > LIB_DEPENDS+= SDL-1.1.5:${PORTSDIR}/devel/sdl12
> > SDL_CONFIG?= ${LOCALBASE}/bin/sdl11-config
> > CONFIGURE_ENV+= SDL_CONFIG="${SDL_CONFIG}"
> > MAKE_ENV+= SDL_CONFIG="${SDL_CONFIG}"
> > SDL_LIBS!= ${SDL_CONFIG} --libs | ${SED} -e 's/.*\(-lSDL-[0-9].[0-9]\).*/\1/'
> > .endif
>
> That all looks fine except for the SDL_LIBS!=, which will not work on
> systems that do not have the SDL port already installed.
>
> Kris
>
> ATTACHMENT part 2 application/pgp-signature
__________________________________________________
Do you Yahoo!?
Yahoo! Shopping - Send Flowers for Valentine's Day
http://shopping.yahoo.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030217084903.80946.qmail>