From owner-cvs-src@FreeBSD.ORG Fri Aug 22 19:36:56 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7278D1065676; Fri, 22 Aug 2008 19:36:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 12B408FC16; Fri, 22 Aug 2008 19:36:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m7MJana1007754; Fri, 22 Aug 2008 15:36:49 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Pyun YongHyeon Date: Fri, 22 Aug 2008 14:20:27 -0400 User-Agent: KMail/1.9.7 References: <200808220647.m7M6lAeL097786@repoman.freebsd.org> In-Reply-To: <200808220647.m7M6lAeL097786@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808221420.28017.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Fri, 22 Aug 2008 15:36:49 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8074/Fri Aug 22 13:40:18 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Aug 2008 19:36:56 -0000 On Friday 22 August 2008 02:46:55 am Pyun YongHyeon wrote: > yongari 2008-08-22 06:46:55 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bfe if_bfe.c if_bfereg.h > Log: > SVN rev 181994 on 2008-08-22 06:46:55Z by yongari > > Add a new sysctl node 'dev.bfe.N.stats' that shows various MAC > counters for Rx/Tx statistics. Various counters in ifnet is also > updated with these hardware counters. > > Tested by: kib, Gleb Kurtsou gleb.kurtsou at gmail dot com > Ulrich Spoerlein uspoerlein at gmail dot com I think it's kind of wrong to have sysctl's that print stats in dmesg. You can either have a sysctl that returns a string and uses sbuf's (e.g. vm.phys_free) if you want formatting or even better, you can give each stat it's own sysctl. This is more friendly for people to use when they aren't on the console (e.g. when you ssh into a box). -- John Baldwin