From owner-freebsd-current@FreeBSD.ORG  Sun Jan 23 15:44:33 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9380916A4CE
	for <freebsd-current@FreeBSD.org>;
	Sun, 23 Jan 2005 15:44:33 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A060343D5A
	for <freebsd-current@FreeBSD.org>;
	Sun, 23 Jan 2005 15:44:32 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0NFiVsP036878;
	Sun, 23 Jan 2005 16:44:31 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Jeremie Le Hen <jeremie@le-hen.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 23 Jan 2005 16:33:26 +0100."
             <20050123153326.GN36660@obiwan.tataz.chchile.org> 
Date: Sun, 23 Jan 2005 16:44:31 +0100
Message-ID: <36877.1106495071@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: freebsd-current@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/md md.c 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jan 2005 15:44:33 -0000

In message <20050123153326.GN36660@obiwan.tataz.chchile.org>, Jeremie Le Hen wr
ites:
>> What kind of filesystem is /boot ?  Is it ufs or something else ?
>
>Yes, it's UFS1.

Ok: even more asserts.  Please try to find out exactly which one
explodes.

==== //depot/user/phk/phk_bufwork/sys/dev/md/md.c#21 - /bang/p4/phk/phk_bufwork/sys/dev/md/md.c ====
@@ -506,16 +506,25 @@
 	 * the data.  When writing IO_DIRECT is not optimal.
 	 */
 	if (bp->bio_cmd == BIO_READ) {
+		mtx_assert(&Giant, MA_OWNED);
 		vn_lock(sc->vnode, LK_EXCLUSIVE | LK_RETRY, curthread);
+		mtx_assert(&Giant, MA_OWNED);
 		error = VOP_READ(sc->vnode, &auio, IO_DIRECT, sc->cred);
+		mtx_assert(&Giant, MA_OWNED);
 		VOP_UNLOCK(sc->vnode, 0, curthread);
 	} else {
+		mtx_assert(&Giant, MA_OWNED);
 		(void) vn_start_write(sc->vnode, &mp, V_WAIT);
+		mtx_assert(&Giant, MA_OWNED);
 		vn_lock(sc->vnode, LK_EXCLUSIVE | LK_RETRY, curthread);
+		mtx_assert(&Giant, MA_OWNED);
 		error = VOP_WRITE(sc->vnode, &auio,
 		    sc->flags & MD_ASYNC ? 0 : IO_SYNC, sc->cred);
+		mtx_assert(&Giant, MA_OWNED);
 		VOP_UNLOCK(sc->vnode, 0, curthread);
+		mtx_assert(&Giant, MA_OWNED);
 		vn_finished_write(mp);
+		mtx_assert(&Giant, MA_OWNED);
 	}
 	bp->bio_resid = auio.uio_resid;
 	return (error);
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.