From owner-cvs-all Mon Apr 1 18:51:21 2002 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id DD9FF37B416; Mon, 1 Apr 2002 18:51:13 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id A2CD67830D; Tue, 2 Apr 2002 12:21:11 +0930 (CST) Date: Tue, 2 Apr 2002 12:21:11 +0930 From: Greg 'groggy' Lehey To: Jake Burkholder Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/kern kern_ktr.c src/sys/sys ktr.h src/sys/sparc64/sparc64 genassym.c Message-ID: <20020402122111.A20507@wantadilla.lemis.com> References: <200204010535.g315ZQQ22659@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200204010535.g315ZQQ22659@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday, 31 March 2002 at 21:35:26 -0800, Jake Burkholder wrote: > jake 2002/03/31 21:35:26 PST > > Modified files: > sys/conf options > sys/kern kern_ktr.c > sys/sys ktr.h > sys/sparc64/sparc64 genassym.c > Log: > ktr changes to improve performance and make writing a userland utility to > dump the trace buffer feasible. > - Remove KTR_EXTEND. This changes the format of the trace entries when > activated, making writing a userland tool which is not tied to a specific > kernel configuration difficult. > > These changes will break gdb macros to decode the extended version > of the trace buffer which are floating around. Users of these > macros should either use the show ktr command in ddb, or use the > userland utility which can be run on a core dump. I really think this is wrong. It removes a very useful debugging tool. IIRC it was possible to disable KTR_EXTEND when necessary. Even if not, it was still an option, and I think it should remain one. There are plenty of places where you won't be able to use the userland tool. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message