From owner-freebsd-bugs@FreeBSD.ORG Mon May 7 09:40:08 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F7C1106564A for ; Mon, 7 May 2012 09:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4F8AE8FC15 for ; Mon, 7 May 2012 09:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q479e8Hn088702 for ; Mon, 7 May 2012 09:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q479e8AN088701; Mon, 7 May 2012 09:40:08 GMT (envelope-from gnats) Date: Mon, 7 May 2012 09:40:08 GMT Message-Id: <201205070940.q479e8AN088701@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Erwin Van de Velde Cc: Subject: Re: kern/166840: [quota] used block count increases but does not decrease X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Erwin Van de Velde List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2012 09:40:08 -0000 The following reply was made to PR kern/166840; it has been noted by GNATS. From: Erwin Van de Velde To: bug-followup@freebsd.org, johan.bergs@gmail.com Cc: Subject: Re: kern/166840: [quota] used block count increases but does not decrease Date: Mon, 7 May 2012 11:26:51 +0200 --14dae9340bdff4314c04bf6edfc3 Content-Type: text/plain; charset=ISO-8859-1 Found another problem report pointing to this (Thanks to koobs, Barnerd from IRC :-) ): - PR Kern/164734 Potential patch ( http://tips.paddyonline.net/index.php/FreeBSD_9.0_issues_with_Quota): diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index 5b4b6b9..ed2db79 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$"); #include "opt_ffs.h" +#include "opt_quota.h" #include "opt_ddb.h" /* @@ -6428,7 +6429,7 @@ softdep_setup_freeblocks(ip, length, flags) } #ifdef QUOTA /* Reference the quotas in case the block count is wrong in the end. */ - quotaref(vp, freeblks->fb_quota); + quotaref(ITOV(ip), freeblks->fb_quota); (void) chkdq(ip, -datablocks, NOCRED, 0); #endif freeblks->fb_chkcnt = -datablocks; Did not test it myself yet. --14dae9340bdff4314c04bf6edfc3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Found another problem report pointing to this (Thanks to koobs, Barnerd fro= m IRC :-) ):
- PR Kern/164734



diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/f= fs/ffs_softdep.c
index 5b4b6b9..ed2db79 100644
--- a/sy= s/ufs/ffs/ffs_softdep.c
+++ b/sys/ufs/ffs/ffs_softdep.c
@@ -43,6 +43,7 @@
=A0__FBSDID("$FreeBSD$");
<= div>=A0
=A0#include "opt_ffs.h"
+#include &qu= ot;opt_quota.h"
=A0#include "opt_ddb.h"
= =A0
=A0/*
@@ -6428,7 +6429,7 @@ softdep_setup_freeblocks(ip, len= gth, flags)
=A0 }
=A0#ifdef QUOTA
=A0 /* Reference the quotas in ca= se the block count is wrong in the end. */
- quot= aref(vp, freeblks->fb_quota);
+ quotaref(ITOV(ip), freeblks->fb_quota)= ;
=A0 (v= oid) chkdq(ip, -datablocks, NOCRED, 0);
=A0#endif
=A0 freeblks->= ;fb_chkcnt =3D -datablocks;


Did not test it myself yet.
<= div>
--14dae9340bdff4314c04bf6edfc3--