From owner-freebsd-current@FreeBSD.ORG Sun Jul 31 14:26:59 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5206816A41F for ; Sun, 31 Jul 2005 14:26:59 +0000 (GMT) (envelope-from chris@haakonia.hitnet.rwth-aachen.de) Received: from ms-dienst.rz.rwth-aachen.de (ms-1.rz.RWTH-Aachen.DE [134.130.3.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id B90FE43D45 for ; Sun, 31 Jul 2005 14:26:58 +0000 (GMT) (envelope-from chris@haakonia.hitnet.rwth-aachen.de) Received: from r220-1 (r220-1.rz.RWTH-Aachen.DE [134.130.3.31]) by ms-dienst.rz.rwth-aachen.de (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0IKH008X8XGWY8@ms-dienst.rz.rwth-aachen.de> for current@freebsd.org; Sun, 31 Jul 2005 16:26:57 +0200 (MEST) Received: from relay.rwth-aachen.de ([134.130.3.1]) by r220-1 (MailMonitor for SMTP v1.2.2 ) ; Sun, 31 Jul 2005 16:26:56 +0200 (MEST) Received: from bigboss.hitnet.rwth-aachen.de (bigspace.hitnet.RWTH-Aachen.DE [137.226.181.2]) by relay.rwth-aachen.de (8.13.3/8.13.3/1) with ESMTP id j6VEQu9E029357 for ; Sun, 31 Jul 2005 16:26:56 +0200 (MEST) Received: from moria.hitnet.rwth-aachen.de ([137.226.181.149] helo=haakonia.hitnet.rwth-aachen.de) by bigboss.hitnet.rwth-aachen.de with esmtp (Exim 3.35 #1 (Debian)) id 1DzEmF-00074a-00 for ; Sun, 31 Jul 2005 16:26:55 +0200 Received: by haakonia.hitnet.rwth-aachen.de (Postfix, from userid 1001) id C69CC28466; Sun, 31 Jul 2005 16:26:25 +0200 (CEST) Date: Sun, 31 Jul 2005 16:26:25 +0200 From: Christian Brueffer To: current@freebsd.org Message-id: <20050731142625.GC1190@unixpages.org> MIME-version: 1.0 Content-type: multipart/signed; boundary=eheScQNz3K90DVRs; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-disposition: inline User-Agent: Mutt/1.5.6i X-Operating-System: FreeBSD 5.4-STABLE X-PGP-Key: http://people.FreeBSD.org/~brueffer/brueffer.key.asc X-PGP-Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D Cc: Subject: [PATCH] fwip(4) panic on attach X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2005 14:26:59 -0000 --eheScQNz3K90DVRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, in CURRENT and RELENG_6 I get a reproducible panic with fwip(4) when plugging in my firewire cardbus card. The following patch fixes it, but I'm not sure if it's correct. The interface works after applying the patch. Index: if_fwip.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /data/ncvs/freebsd/src/sys/dev/firewire/if_fwip.c,v retrieving revision 1.7 diff -u -r1.7 if_fwip.c --- if_fwip.c 10 Jun 2005 16:49:08 -0000 1.7 +++ if_fwip.c 31 Jul 2005 14:01:52 -0000 @@ -171,11 +171,13 @@ =20 fwip =3D ((struct fwip_softc *)device_get_softc(dev)); unit =3D device_get_unit(dev); + =20 + bzero(fwip, sizeof(struct fwip_softc)); + ifp =3D fwip->fw_softc.fwip_ifp =3D if_alloc(IFT_IEEE1394); if (ifp =3D=3D NULL) return (ENOSPC); =20 - bzero(fwip, sizeof(struct fwip_softc)); /* XXX */ fwip->dma_ch =3D -1; - Christian --=20 Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D --eheScQNz3K90DVRs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFC7N+RbHYXjKDtmC0RApnwAKDde5C59jf3ClLDyIhIxA7org+lVgCg3oiL /kOFAtFPCLoPciPk8Nbhr3k= =OXHA -----END PGP SIGNATURE----- --eheScQNz3K90DVRs--