From owner-freebsd-stable@FreeBSD.ORG  Thu Feb 17 19:52:51 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BAAE916A4CE; Thu, 17 Feb 2005 19:52:51 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 39E2043D2D; Thu, 17 Feb 2005 19:52:51 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [IPv6:::1])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id j1HJpbTa001186;
	Thu, 17 Feb 2005 12:51:38 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Thu, 17 Feb 2005 12:51:37 -0700 (MST)
Message-Id: <20050217.125137.74752166.imp@bsdimp.com>
To: maxim@macomnet.ru
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20050217212655.E14434@mp2.macomnet.net>
References: <420A1792.900@DeepCore.dk>
	<421464C3.2030308@DeepCore.dk>
	<20050217212655.E14434@mp2.macomnet.net>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: freebsd-current@freebsd.org
cc: freebsd-stable@freebsd.org
cc: sos@DeepCore.dk
Subject: Re: UPDATE2: ATA mkIII first official patches - please test!
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Feb 2005 19:52:51 -0000

> atadisk.ko and atapicd.ko still do not depend on atapci.ko.  So if you
> don't ask to load atapci.ko in loader.conf you will get a panic
> because the kernel won't find the root fs.  I added MODULE_DEPEND() on
> atapci macro to ata-disk.c and this solved the problem.  Perhaps this
> is just a feature.

MODULE_DEPEND should only be there when when there's a link time
dependency between modles.  If you were to add the atapci.ko as a
depend, then you destroy the ability to boot on machines that don't
have a pci bus in the kernel....

Warner