From owner-cvs-usrbin  Mon May 15 00:32:01 1995
Return-Path: cvs-usrbin-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id AAA20643
          for cvs-usrbin-outgoing; Mon, 15 May 1995 00:32:01 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA20636
          ; Mon, 15 May 1995 00:31:55 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id AAA05385; Mon, 15 May 1995 00:31:18 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199505150731.AAA05385@gndrsh.aac.dev.com>
Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c
To: vode@freud.hut.fi (Kai Vorma)
Date: Mon, 15 May 1995 00:31:18 -0700 (PDT)
Cc: nate@trout.sri.MT.net, ache@freefall.cdrom.com,
        CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com
In-Reply-To: <Pine.HPP.3.91.950515090939.6388B-100000@freud.hut.fi> from "Kai Vorma" at May 15, 95 09:28:56 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1309      
Sender: cvs-usrbin-owner@freebsd.org
Precedence: bulk

> 
> 
> 
> On Sun, 14 May 1995, Nate Williams wrote:
> 
> > Andrey A. Chernov writes:
> > > ache        95/05/14 17:03:33
> > > 
> > >   Modified:    usr.bin/rpcgen  rpc_parse.c
> > >   Log:
> > >   End of listcan be not marked, fix it
> > >   Submitted by: Kai Vorma <vode@snakemail.hut.fi>
> > 
> > I looked at this fix, and I'm not sure that the proposed 'fix' was
> > necessary.  Did you look at the fix at determine if it was indeed needed?
> 
> Without this fix the last plist->next link is uninitialized. rpcgen
> still works, because the way BSD malloc works (it cannot reuse freed
> memory so it asks more from the system and that memory is zeroed ->
> next-link happens to be NULL). 
> 
> I have replaced the system malloc with a better one and rpcgen
> dumps core without this patch.

Then this is not a critical bug fix, becuase as ship freebsd does not
have the bug!

Are you *absolutely* sure your change has no side effects that would
cause something else to break?  If so I can live with this change,
if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c
and obsolete this last change until after the release is done.

-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD