From owner-freebsd-current@FreeBSD.ORG Thu Nov 17 19:30:25 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87C7716A41F; Thu, 17 Nov 2005 19:30:25 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 987B743D45; Thu, 17 Nov 2005 19:30:24 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2131829 for multiple; Thu, 17 Nov 2005 14:30:20 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jAHJUDoa024776; Thu, 17 Nov 2005 14:30:13 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Mike Tancsa Date: Thu, 17 Nov 2005 12:56:01 -0500 User-Agent: KMail/1.8.2 References: <20051117010651.97608.qmail@web50303.mail.yahoo.com> <200511171135.53903.jhb@freebsd.org> <6.2.3.4.0.20051117120533.057ddae0@64.7.153.2> In-Reply-To: <6.2.3.4.0.20051117120533.057ddae0@64.7.153.2> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511171256.04056.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: alan bryan , Alexander Leidinger , freebsd-current@freebsd.org, FreeBSD current mailing list , "Bjoern A. Zeeb" Subject: Re: [PATCH] nve(4) locking cleanup X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2005 19:30:25 -0000 On Thursday 17 November 2005 12:08 pm, Mike Tancsa wrote: > At 11:35 AM 17/11/2005, John Baldwin wrote: > >Hmm, there are a couple of changes such as calling pfnInit() in attach() > > and calling pfnClearTXDesc() in nve_stop() that might be interesting. > > I've stuck those in my work tree and have made a seperate patch relative > > to HEAD if folks want to try them out: > > > >http://www.FreeBSD.org/~jhb/patches/nve_dffixes.patch > > On a RELENG_6 kernel with the drivers from HEAD with the above patch > applied, driver loaded as kld, > > the box does not seem to crash, but the nic does wedge > > nve0: link state changed to DOWN > nve0: link state changed to UP > nve0: link state changed to DOWN > nve0: link state changed to UP > nve0: device timeout (64) > nve0: link state changed to DOWN > nve0: link state changed to UP > nve0: link state changed to DOWN > nve0: link state changed to UP > > while generating a lot of 2 way traffic. > > This is a Tyan 939 board. > > Trying to mount root from ufs:/dev/da0s1a > nve0: port 0xe400-0xe407 mem > 0xfebfc000-0xfebfcfff irq 23 at device 10.0 on pci0 > nve0: Ethernet address 00:e0:81:58:91:fa > miibus2: on nve0 > ukphy0: on miibus2 > ukphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, > 1000baseT-FDX, auto > nve0: Ethernet address: 00:e0:81:58:91:fa > nve0: [GIANT-LOCKED] Did it work before? Is the new behavior better or worse than the unpatched driver? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org