From nobody Mon Apr 13 19:54:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fvdRH152Tz6ZdG7 for ; Mon, 13 Apr 2026 19:54:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fvdRG4plZz3n8K for ; Mon, 13 Apr 2026 19:54:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776110090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fv1Zc2ttNVQiGwnLyUDSDwGPzl3/ZjpUUA23vpefWv0=; b=A1DEYoWNLkmMk9GkU7txW3Tv0NnbbqGe0PAs2hRf/N0is7rwtqdlGcDmA8fz2rFIwvLLXr GdTkOwArrqYtlECPz8zakF6cDeb4KdOOQRWOsShNZLsAWoccCHzdY7Ui2R72p7QYNfnLOS +WpYWyJWm4I79znDfusn+LsUvQ9DhFr5nXePq/wa5EWyJZPc+W08zDICPnSPIKWXAKjDMA Tgp1ztgm7D8ONqc5odwfG65VnRu6gH25Bukly9PFe2MX++1M7JkScX3y+WtcbQ1kBUmd2l XENTkNOjrgIOEEF922kJBnAfhT3r8A9RaZOWVOULHh4TcIgRBT6bBZri2vTstQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776110090; a=rsa-sha256; cv=none; b=Ikv4Bo8TBOouGqDbYMftlWbS1aYDqnZ/RXS0dUxVN03/AlLAPJQ6GvJ8AIeouGfa7rDUAl viTueoE9mAwlPbeW1d0V8HWmbwFy9T1u98sZmFf0M3GFT0HWf4fkBG2l9I0YZ2eArVUiFc jZqxbKrJzw3gaGpIbwueBNfMJYWIVWUjXXYaECNtbWMPMYr6ReAAroC7v2lc4A1WZc8EFN BdK3Cw+wVlCUDQgCbSyHqBvcDzNZpaiNSLBEKsOlZX6oYxJUCPDWgHoJLElMu1uwZv1BDy OTWtYe1hyjqUNbACwlOHlKXoYqzMr8WLAPpyezHfX2K18lVZsei5d0Z+EYUK6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776110090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fv1Zc2ttNVQiGwnLyUDSDwGPzl3/ZjpUUA23vpefWv0=; b=l4E1nlh90T6aehIFYb3FmHQP2R3b5gYQLewa80wO/O2YXpRfutr2clbZux/G6XseDFV5QY Om1BOjC68BmRsbsQRx3b0eAgEoviHK2GXFDLmq7V2mCwW0K4MxmpBB6J7L3HVn2+6q/SJ0 necI+M9dXcN7DST4VdDHNLoI5OciLYpIoz0j9PpJcDpepoDZQe9HFcO4/7vvdVf5gC/bUT 8FKr5RRRkxGSanhPwwbnCbVFTotH9JDVw3cST6E/75Zib8VMNQ41spsfSaCrWk3CYHar71 ZciB6AoWHdooYFkTQsE+rrPJT/iVrbcu2KivJlPuplloFP4XwttR+jVegH73Vg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fvdRG3zbpz3Zh for ; Mon, 13 Apr 2026 19:54:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41b2d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 13 Apr 2026 19:54:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Matt Delco From: Alexander Ziaee Subject: git: 4d6fb9d57b8a - stable/15 - nvme: Removed unused 'regs' variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ziaee X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4d6fb9d57b8aa77b0e5b9650540f3a01d4ef7972 Auto-Submitted: auto-generated Date: Mon, 13 Apr 2026 19:54:50 +0000 Message-Id: <69dd4a0a.41b2d.11136efb@gitrepo.freebsd.org> The branch stable/15 has been updated by ziaee: URL: https://cgit.FreeBSD.org/src/commit/?id=4d6fb9d57b8aa77b0e5b9650540f3a01d4ef7972 commit 4d6fb9d57b8aa77b0e5b9650540f3a01d4ef7972 Author: Matt Delco AuthorDate: 2026-03-10 19:30:51 +0000 Commit: Alexander Ziaee CommitDate: 2026-04-13 19:54:16 +0000 nvme: Removed unused 'regs' variable The private struct has a 'regs' member that's only written to and otherwise unused. This change removes it. Fixes: b3d9e5013f3e5 (Don't active memory space) Requested by: jhb Reviewed by: imp, jhb, jrtc27 Differential Revision: https://reviews.freebsd.org/D55817 (cherry picked from commit 4e3beef84628ce6dfea7f053cddf3289fddf7794) --- sys/dev/nvme/nvme_ahci.c | 1 - sys/dev/nvme/nvme_pci.c | 1 - sys/dev/nvme/nvme_private.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/sys/dev/nvme/nvme_ahci.c b/sys/dev/nvme/nvme_ahci.c index b06661226d34..dd005dd868de 100644 --- a/sys/dev/nvme/nvme_ahci.c +++ b/sys/dev/nvme/nvme_ahci.c @@ -79,7 +79,6 @@ nvme_ahci_attach(device_t dev) } ctrlr->bus_tag = rman_get_bustag(ctrlr->resource); ctrlr->bus_handle = rman_get_bushandle(ctrlr->resource); - ctrlr->regs = (struct nvme_registers *)ctrlr->bus_handle; /* Allocate and setup IRQ */ ctrlr->rid = 0; diff --git a/sys/dev/nvme/nvme_pci.c b/sys/dev/nvme/nvme_pci.c index 8e5e64e1f0e0..f2b9465294f6 100644 --- a/sys/dev/nvme/nvme_pci.c +++ b/sys/dev/nvme/nvme_pci.c @@ -225,7 +225,6 @@ nvme_ctrlr_allocate_bar(struct nvme_controller *ctrlr) ctrlr->bus_tag = rman_get_bustag(ctrlr->resource); ctrlr->bus_handle = rman_get_bushandle(ctrlr->resource); - ctrlr->regs = (struct nvme_registers *)ctrlr->bus_handle; return (0); } diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h index 8b5737dfb72b..9cfe9c32b360 100644 --- a/sys/dev/nvme/nvme_private.h +++ b/sys/dev/nvme/nvme_private.h @@ -286,8 +286,6 @@ struct nvme_controller { struct nvme_qpair adminq; struct nvme_qpair *ioq; - struct nvme_registers *regs; - struct nvme_controller_data cdata; struct nvme_namespace ns[NVME_MAX_NAMESPACES];