From owner-svn-src-stable@FreeBSD.ORG Fri May 4 19:47:56 2012 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E15021065674; Fri, 4 May 2012 19:47:56 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe08.c2i.net [212.247.154.226]) by mx1.freebsd.org (Postfix) with ESMTP id 9BD2F8FC15; Fri, 4 May 2012 19:47:55 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED Received: from [176.74.212.201] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe08.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 271298319; Fri, 04 May 2012 21:42:45 +0200 From: Hans Petter Selasky To: Warner Losh Date: Fri, 4 May 2012 21:41:55 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.3-STABLE; KDE/4.4.5; amd64; ; ) References: <201205041538.q44FclqK010547@svn.freebsd.org> <201205041826.19435.hselasky@c2i.net> In-Reply-To: X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp |U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI -%GU9V5]iUZF&nRn9mJ'?&>O MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201205042141.55089.hselasky@c2i.net> Cc: "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "svn-src-stable-9@freebsd.org" , John Baldwin Subject: Re: svn commit: r235007 - stable/9/sys/dev/pci X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 19:47:57 -0000 On Friday 04 May 2012 19:18:56 Warner Losh wrote: > On May 4, 2012, at 10:26 AM, Hans Petter Selasky wrote: > > On Friday 04 May 2012 18:14:16 John Baldwin wrote: > >> On Friday, May 04, 2012 11:38:47 am Hans Petter Selasky wrote: > >>> Author: hselasky > >>> Date: Fri May 4 15:38:47 2012 > >>> New Revision: 235007 > >>> URL: http://svn.freebsd.org/changeset/base/235007 > >>> > >>> Log: > >>> MFC r233662, r233677 and r233678: > >>> > >>> Writing zero to BAR actually does not disable it and > >>> it is even harmful as hselasky found out. Historically, > >>> this code was originated from (OLDCARD) CardBus driver and later > >>> leaked into PCI driver when CardBus was newbus'ified and refactored > >>> with PCI driver. However, it is not really necessary even for > >>> CardBus. > >> > >> FYI, I've got one bug report on HEAD where these changes broke a > >> machine's ATA controller. > > > > Have you considered adding code to disable the I/O or memory range > > instead of writing 0 to the bar in this case? > > I tried that once upon a time, but was problematical with some bridges that > had BARs at non-standard locations that needed the I/O or MEM bit set in > order to work... > > Warner If the size of the bar is a few megabytes, then moving it to location 0 is definitely wrong. Else it might work! --HPS