From owner-cvs-src@FreeBSD.ORG  Thu Mar 25 16:16:38 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1D0CE16A4CE; Thu, 25 Mar 2004 16:16:38 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9EAB143D3F; Thu, 25 Mar 2004 16:16:37 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.10/8.12.9) with ESMTP id i2Q0GZkj035585;
	Thu, 25 Mar 2004 17:16:35 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Thu, 25 Mar 2004 17:16:34 -0700 (MST)
Message-Id: <20040325.171634.59655793.imp@bsdimp.com>
To: alfred@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040325234024.GJ26131@elvis.mu.org>
References: <xzpvfksfztc.fsf@dwp.des.no>
	<20040325.151018.82302651.imp@bsdimp.com>
	<20040325234024.GJ26131@elvis.mu.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: des@des.no
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
cc: wpaul@freebsd.org
Subject: Re: cvs commit: src/sys/compat/ndis kern_ndis.c subr_ndis.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2004 00:16:38 -0000

In message: <20040325234024.GJ26131@elvis.mu.org>
            Alfred Perlstein <alfred@freebsd.org> writes:
: * M. Warner Losh <imp@bsdimp.com> [040325 14:11] wrote:
: > In message: <xzpvfksfztc.fsf@dwp.des.no>
: >             des@des.no (Dag-Erling Sm?rgrav) writes:
: > : Bill Paul <wpaul@FreeBSD.org> writes:
: > : 
: > : des@dwp ~% gf BUS_GET_RESOURCE_LIST
: > : qsrc/sys/compat/ndis/kern_ndis.c:       brl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev);
: > : src/sys/dev/if_ndis/if_ndis_pci.c:      rl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev);
: > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
: > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
: > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
: > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
: > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
: > 
: > Acutally, there are alot of downstream users of rl.
: 
: :(
: 
: Shouldn't we have macros:
: 
: BUS_GET_RESOURCE_NEXT ?
: 
: (instead of SLIST_NEXT)

We already do.  bus_generic_rl_get_resource, et al.  The problem here
is that the pci bus never intended its resources to be exposed outside
of the bus layer.  But windows drivers need it, so there needs to be
some tweaks need to be made.

It looks like I was incorrect about the downstream uses of it.  I
thought that pci and pccard did that, but it appears that they now use
the common functions that matt dodd moved into subr_bus a while ago.

Warner