Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Mar 2021 17:39:46 +0100
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        "George V. Neville-Neil" <gnn@FreeBSD.org>, ports-committers@freebsd.org,  svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r568015 - in head/net/tcptestsuite: . files
Message-ID:  <9042c008-1c7a-6869-9a16-6fb122ae8933@FreeBSD.org>
In-Reply-To: <202103101630.12AGUOgO080547@repo.freebsd.org>
References:  <202103101630.12AGUOgO080547@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hey George,

On 10/03/2021 17:30, George V. Neville-Neil wrote:
> Author: gnn (src committer)
> Date: Wed Mar 10 16:30:24 2021
> New Revision: 568015
> URL: https://svnweb.freebsd.org/changeset/ports/568015
>
> Log:
>    Take maintainership of the port and add updated files.
>    
>    The addition of the Kyuafile and tcptestsuite_atf_test script
>    make running the tests, once installed, simpler and easier
>    than in the past, e.g.
>    
>    cd /usr/local/tests
>    sudo kyua -v test_suites.FreeBSD.allow_sysctl_side_effects=1 test
>    
>    Submitted by: Olivier Cochard
>    Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
>
> Added:
>    head/net/tcptestsuite/files/
>    head/net/tcptestsuite/files/Kyuafile   (contents, props changed)
>    head/net/tcptestsuite/files/tcptestsuite_atf_test   (contents, props changed)
> Modified:
>    head/net/tcptestsuite/Makefile
>    head/net/tcptestsuite/distinfo
>    head/net/tcptestsuite/pkg-plist
>
> Modified: head/net/tcptestsuite/Makefile
> ==============================================================================
> --- head/net/tcptestsuite/Makefile	Wed Mar 10 16:28:25 2021	(r568014)
> +++ head/net/tcptestsuite/Makefile	Wed Mar 10 16:30:24 2021	(r568015)
> @@ -1,10 +1,10 @@
>   # $FreeBSD$
>   
>   PORTNAME=	tcptestsuite
> -PORTVERSION=	0.0.4
> +DISTVERSION=	g20210304
We should probably set PORTEPOCH=1.

```
$ pkg version -t 0.0.4 g20210304
 >
```

>   CATEGORIES=	net
>   
> -MAINTAINER=	ports@FreeBSD.org
> +MAINTAINER=	gnn@FreeBSD.org
>   COMMENT=	Network stack test suite
>   
>   LICENSE=	BSD2CLAUSE
> @@ -21,7 +21,10 @@ NO_BUILD=	yes
>   
>   do-install:
>   	${INSTALL_SCRIPT} ${WRKSRC}/run-all-tests ${STAGEDIR}${PREFIX}/bin
> +	${MKDIR} ${STAGEDIR}${PREFIX}/tests/tcptestsuite
>   	(cd ${WRKSRC} && \
>   		${COPYTREE_SHARE} "fast-open snd-syn socket-api rcv-data-segments rcv-icmp snippets state-event-engine" ${STAGEDIR}${DATADIR})
> +	${INSTALL_SCRIPT} ${FILESDIR}/tcptestsuite_atf_test ${STAGEDIR}${PREFIX}/tests/
> +	${INSTALL_DATA} ${FILESDIR}/Kyuafile ${STAGEDIR}${PREFIX}/tests/
>   
Shouldn't that beĀ  ${STAGEDIR}${PREFIX}/tests/tcptestsuite?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9042c008-1c7a-6869-9a16-6fb122ae8933>