From owner-cvs-all Tue Sep 11 10: 1:28 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (sentinel.office1.bg [217.75.135.254]) by hub.freebsd.org (Postfix) with SMTP id 4A99F37B401 for ; Tue, 11 Sep 2001 10:00:49 -0700 (PDT) Received: (qmail 31465 invoked by uid 1000); 11 Sep 2001 16:40:58 -0000 Date: Tue, 11 Sep 2001 19:40:58 +0300 From: Peter Pentchev To: Ruslan Ermilov Cc: Matt Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/libexec/uucp/cu Makefile src/gnu/libexec/uucp/uucp Makefile src/gnu/libexec/uucp/uuname Makefile src/gnu/libexec/uucp/uustat Makefile src/gnu/libexec/uucp/uux Makefile src/usr.bin/tip/tip Makefile Message-ID: <20010911194057.A30505@ringworld.oblivion.bg> Mail-Followup-To: Ruslan Ermilov , Matt Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200109102230.f8AMUS561400@freefall.freebsd.org> <20010911101209.B4979@sunbay.com> <20010911131419.B47107@ringworld.oblivion.bg> <20010911144812.B43697@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010911144812.B43697@sunbay.com>; from ru@FreeBSD.org on Tue, Sep 11, 2001 at 02:48:12PM +0300 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Sep 11, 2001 at 02:48:12PM +0300, Ruslan Ermilov wrote: > On Tue, Sep 11, 2001 at 01:14:19PM +0300, Peter Pentchev wrote: > > On Tue, Sep 11, 2001 at 10:12:09AM +0300, Ruslan Ermilov wrote: > > > BTW, INSTALLFLAGS+= is the style bug, it should be written as > > > INSTALLFLAGS=. INSTALLFLAGS are left to individual Makefiles, > > > like SRCS, PROG, MAN, hence Makefile should initialize them. > > > CFLAGS on the contrast aren't. > > > > INSTALLFLAGS+= allows the user to specify different (additional) > > flags on the command line. > This isn't useful in the general sense (for the entire /usr/src > trip). True, but it is useful for developers working on a single program, and for the occassional 'power user' who wants to update a single program. With += there is no need to hack the Makefile and then remember to remove this particular hack before committing. > Also, changing INSTALLFLAGS after .include > doesn't work, as it is used in the assignment. True, but irrelevant in this case: all of Matt's changes were placed before the .include . A INSTALLFLAGS=foo on the make(1) command line will also be processed before the .include . > Before this change, > this looked like this: [snip] > Note, there were only two exceptions to this rule. > If you want to install your world with -C, you > way want to change the INSTALL, as documented in > make.conf(5). Hm. Okay; now *this* is a good point; I'd completely forgotten about the INSTALL variable itself. Okay, I'll shut up now :) G'luck, Peter -- This inert sentence is my body, but my soul is alive, dancing in the sparks of your brain. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message