Date: Wed, 08 May 1996 01:33:04 +0800 From: Peter Wemm <peter@spinner.DIALix.COM> To: Poul-Henning Kamp <phk@critter.tfs.com> Cc: smp@freebsd.org Subject: Re: comments Message-ID: <199605071733.BAA00987@spinner.DIALix.COM> In-Reply-To: Your message of "Tue, 07 May 1996 14:21:44 GMT." <12723.831478904@critter.tfs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> >I spent a couple of minutes with the current code and noticed >only a few things: > >1. the PG_N bit should be set on the apic page. Yes, I guess so.. >2. apic_startup is never called. I know.. :-) I have a pile of pending commits, I had it running again for a moment last night. >3. expect_mplock should check smp_active I think. > >4. the apic isn't mapped I think... Yes, it is. :-) I can get both cpu0 and cpu1 to panic.. >Poul-Henning I missed a lot of things in the last commit, some of the more serious were because of my lack of general i386 assembler knowledge.. ie: stuff that could not possibly work. And forgetting to call apic_startup was one of the classics.... I'll commit where I'm up to in a moment. Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199605071733.BAA00987>