From owner-svn-src-all@freebsd.org  Tue Jul 14 10:28:27 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FEEE99C1E8;
 Tue, 14 Jul 2015 10:28:27 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 1E1AFB50;
 Tue, 14 Jul 2015 10:28:22 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA09852;
 Tue, 14 Jul 2015 13:28:21 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1ZExRk-0000Qe-Ob; Tue, 14 Jul 2015 13:28:20 +0300
Message-ID: <55A4E40C.3090608@FreeBSD.org>
Date: Tue, 14 Jul 2015 13:27:24 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Slawa Olhovchenkov <slw@zxy.spb.ru>
CC: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-vendor@FreeBSD.org
Subject: Re: svn commit: r285025 - vendor-sys/illumos/dist/uts/common/fs/zfs
References: <201507021101.t62B1SlK075159@repo.freebsd.org>
 <20150712135246.GA43740@zxy.spb.ru>
In-Reply-To: <20150712135246.GA43740@zxy.spb.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 10:28:27 -0000

On 12/07/2015 16:52, Slawa Olhovchenkov wrote:
> On Thu, Jul 02, 2015 at 11:01:28AM +0000, Andriy Gapon wrote:
> 
>> Author: avg
>> Date: Thu Jul  2 11:01:27 2015
>> New Revision: 285025
>> URL: https://svnweb.freebsd.org/changeset/base/285025
>>
>> Log:
>>   6033 arc_adjust() should search MFU lists for oldest buffer when adjusting MFU size
>>   
>>   illumos/illumos-gate@31c46cf23cd1cf4d66390a983dc5072d7d299ba2
>>   
>>   https://www.illumos.org/issues/6033
>>     When we're looking for the list containing oldest buffer we never actually look
>>     at the MFU lists even when we try to evict from MFU.
>>     looks like a copy paste error, the fix is here:
>>   
>>   Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
>>   Reviewed by: Xin Li <delphij@delphij.net>
>>   Reviewed by: Prakash Surya <me@prakashsurya.com>
>>   Approved by: Matthew Ahrens <mahrens@delphix.com>
>>   Author: Alek Pinchuk <alek@nexenta.com>
>>   Obtained from:	illumos
>>
>> Modified:
>>   vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c
>>
> 
> Can you see also at arc_init:4297?
> I see double init arc_mfu_ghost->arcs_lists[i] and no init arc_anon.
> This is correct?
> 

There is no double initialization if you look harder, one initialization is for
data and the other is for metadata.
Buffers in arc_anon state are not placed on a list.

-- 
Andriy Gapon