From owner-cvs-src@FreeBSD.ORG Sat Dec 17 04:55:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F359316A41F; Sat, 17 Dec 2005 04:55:03 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6790743D4C; Sat, 17 Dec 2005 04:54:58 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jBH4svn7022588; Fri, 16 Dec 2005 21:54:58 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43A39A21.6020607@samsco.org> Date: Fri, 16 Dec 2005 21:54:57 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200512170357.jBH3vAhh030893@repoman.freebsd.org> In-Reply-To: <200512170357.jBH3vAhh030893@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=3.8 tests=ALL_TRUSTED, SUBJ_HAS_SPACES autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 04:55:04 -0000 Nate Lawson wrote: > njl 2005-12-17 03:57:10 UTC > > FreeBSD src repository > > Modified files: > sys/sys ktr.h > sys/kern kern_clock.c kern_switch.c > Log: > Clean up unused or poorly utilized KTR values. Remove KTR_FS, KTR_KGDB, > and KTR_IO as they were never used. Remove KTR_CLK since it was only > used for hardclock firing and use KTR_INTR there instead. Remove > KTR_CRITICAL since it was only used for crit enter/exit and use > KTR_CONTENTION instead. > > Revision Changes Path > 1.183 +1 -1 src/sys/kern/kern_clock.c > 1.118 +2 -2 src/sys/kern/kern_switch.c > 1.35 +12 -12 src/sys/sys/ktr.h Um, I was using KTR_CRITICAL for schedgraph. It was actually quite useful. Compressing the option space only makes the options less useful. Surely there has to be a better solution. Or, at least you could call for comments before you alter this stuff. Scott