From owner-svn-src-head@freebsd.org  Sun Apr  8 02:47:39 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09F9DF9BF46;
 Sun,  8 Apr 2018 02:47:39 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 65F9470906;
 Sun,  8 Apr 2018 02:47:38 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w382laNa011394;
 Sat, 7 Apr 2018 19:47:36 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w382la7E011393;
 Sat, 7 Apr 2018 19:47:36 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201804080247.w382la7E011393@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86
In-Reply-To: <20180408023934.GA85042@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Date: Sat, 7 Apr 2018 19:47:36 -0700 (PDT)
CC: Conrad Meyer <cem@freebsd.org>, "Roger Pau Monn??" <royger@freebsd.org>,
 svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Apr 2018 02:47:39 -0000

> On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote:
> > I like something like this for clarity.  But I don't see any reason
> > for these function-like macros instead of the more general definition
> > of an SI prefix constant multiple.  A multiple works with numeric
> > literals and variables alike.  Something like:
> 
> As Bruce had said, 1G is normally written as 1024 * 1024 * 1024 and this
> is clearer than 1 << 30.  Macros/functions like these are evil and bring
> more problems than they solve (again, as Bruce had explained).  GiB name
> is also ugly (correct spelling is GB).  IMHO the whole thing should just
> be removed.

I support this as well.  1K, 1M and 1G can all very easily be express as
products of 1024, and have been expressed that way for most of the life
of the BSD source code.

I would even support this being an addition to style(9).

> ./danfe

-- 
Rod Grimes                                                 rgrimes@freebsd.org