From owner-freebsd-arch@FreeBSD.ORG  Tue Dec 23 12:53:07 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D2E7116A4CE
	for <arch@freebsd.org>; Tue, 23 Dec 2003 12:53:06 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 0BDBC43D53
	for <arch@freebsd.org>; Tue, 23 Dec 2003 12:53:03 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 92460 invoked by uid 1000); 23 Dec 2003 20:53:03 -0000
Date: Tue, 23 Dec 2003 12:53:03 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <XFMail.20031218155821.jhb@FreeBSD.org>
Message-ID: <20031223125146.K92457@root.org>
References: <XFMail.20031218155821.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: arch@freebsd.org
cc: acpi-jp@jp.freebsd.org
Subject: RE: acpi_toshiba and acpi_asus drivers
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Dec 2003 20:53:07 -0000

On Thu, 18 Dec 2003, John Baldwin wrote:
> On 18-Dec-2003 Nate Lawson wrote:
> > I'm prepping/reworking some user-submitted drivers for import.  I'd like
> > some comments on the directory structure.  The hardware both drive is
> > everything from fans to hotkeys to lcd backlight.  Both are very
> > hw-specific and do not conform to the ACPI spec although they do control
> > their functions through ACPI.
> >
> > The directory structure I'm currently working with is:
> >     sys/i386/acpica/acpi_toshiba.c
> >     sys/i386/acpica/acpi_asus.c
> >     sys/modules/acpi_toshiba/Makefile
> >     sys/modules/acpi_asus/Makefile
> >     share/man/man4/acpi_toshiba.4
> >     share/man/man4/acpi_asus.4
> >
> > One alternative is to their modules under the acpi dir (e.g.,
> > sys/modules/acpi/acpi_toshiba).  Also, the driver src could be
> > sys/dev/acpi_toshiba.  However, a new dir for just one file seems a bit
> > much.  My main concern is that as these drivers proliferate that we keep
> > the dir structure neat.
>
> Having a /sys/modules/acpi with acpi, acpi_toshiba, and acpi_asus in
> them is probably a good idea.  Putting the files under sys/i386/acpica
> is also probably ok.  Should the manpages be in man4.i386 rather than
> man4 though?

Ok, this is what I'll be committing:
sys/i386/acpica/acpi_toshiba.c
sys/i386/acpica/acpi_asus.c
sys/modules/acpi/acpi/Makefile
sys/modules/acpi/acpi_toshiba/Makefile
sys/modules/acpi/acpi_asus/Makefile
share/man/man4.i386/acpi_toshiba.4
share/man/man4.i386/acpi_asus.4

-Nate