From owner-svn-src-all@freebsd.org Tue Jan 7 05:43:15 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B5291E1672; Tue, 7 Jan 2020 05:43:15 +0000 (UTC) (envelope-from o.hartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47sLrf4tGqz3FF6; Tue, 7 Jan 2020 05:43:14 +0000 (UTC) (envelope-from o.hartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578375789; bh=EfEvNCPwMIYzOFfQTWNYyi6OOuRohk523XMo1YJBkBw=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=H00uorCO8/ZWRP/VUV5UUD5APBTP9hBtVGSwCmonGs6uqWSKg0H9CwOUw0Xz8RLE+ HJiVPLKakgVWprP0zuvgGLGR/7mh9ayGGIg+Sb9BCYaaulImOd4ajDo/Pj1W+nhee7 OsdZCfqqkTTSPzeBkwA3hD+ea6to6oHSTX/Gm/do= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from freyja ([79.192.173.245]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MD9T1-1ixoRo1rM1-0099S8; Tue, 07 Jan 2020 06:43:09 +0100 Date: Tue, 7 Jan 2020 06:43:02 +0100 From: "O. Hartmann" To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356437 - head/lib/libprocstat Message-ID: <20200107064255.18dad9d2@freyja> In-Reply-To: <202001070533.0075XX7D076100@repo.freebsd.org> References: <202001070533.0075XX7D076100@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qahe+CePIZL9HvBMFdp7eSN7AmBs7GCiK3YNQyt56cyF08rMCnX In9IMGFkyx+T31By8wc9cObGWKlleHoIf/nuLt6Da79XqkigVo7ArpdHuvSUXSVOSJ7yiAr w4t++UyPI37ldyj0rpR9Vi5SAZ04TEN8kcb9koFJpgeu8uu0d0yhdXQUF7vu2ntlBDbuFFZ we8CFoTDQvnT/n5tOsTiA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EOjUw3mA3Dg=:mvck+LlKC3MiuZWByZsj9v 5Zc/dGL0nyVOurUOp+wd57uVXUuDEQ/WV+Cos+eNj9oxk5gkdcJeOISXcE+IRTAbuTjb3pLPc IKe0MQa16Lped9GluvDpbwul+y+cpM2CDXstKA1tN6Zus5R2TXBFTlUnkv1Fx/22KN51PRofU ffyr9M+uzJ0FOE4QQqK81o/sJfc5XzJzZef5qQaFXWmwTuIt8pGRHpUW+SQJ55oksnt0Vl6qF oRVYhLSioO1PJgmgf4dJKGIEpW6Ios/n01S8nHmysgDXzoY4bEQtfNl4uct9WQGyY4XtOsgCM FgdGbA4wg4ugR4S849pEkgtW9rqnj8x7d5Zy/yH8UJ/JO4xZXfeHOhpf7pASdddpQ+lkn7kAW Tfkv9dxF4tRLDUdD/Gb7R0MH3OD1aWfTqpzX/6RuKQ46ojFhh0HIZp7bqJvz+f1X1DwLRiFu4 4FEvGQYjJfXR/L410JCkscSdc/xvNAgRBxGsSAEsBKPVo9YOr0mO9yeHqIShqbMyFyk9IDU9D 3F8ISOoVerbaDvZmSHA7jW9JWxAyRJde2sGhtUcA8RbfXTD+fylKAy+SZJGoXBfsR5ofebALx d9BA6Db5bDk+TRzKR6OyTe4BtVO6pQxffgMwypy2GPgYjNOiDWSzyC837WJ/rdX2ByWtUniSc oqV/Avqa3IEHYwVYPDk051uAMpggnDhskftpqgqgYf7XJ4M+4dfFMcIeT3wzqtel9jWEqAuEp PxSiYbV4ueXwcLXt+eDIqABF17/HLUbybbnFRhQC/TB1E42NkoHX3ETbHAvTnUmKbgjroT5O7 GdIzU6PS3WhTw0DrMw3R9+fPqa0L9pmFFO7fxQ/oqcJLZ/58drVEvSnN0x4SdcvipK6mP2/Go RLmWNqWk3ONbEHczNa5IbXGc1AsOK5lUgp6Z5DHV4Xj2psCvhAIiOQwvO1ohccxmBhY9YPLCR uaGmoOclJ1bJgOP6rrtjKLx1gcVRqenFxfSp8aqJsKxjo3B1V05R0ggiyaiw+HxyEWh64YMvb +wDULegsBFPk8rn2G90FqGesd1kwOvJ067UQDh10VRRr6XL4uN/ujisWA6EOFKB6QMGg3s6HU o4wotxGxhObwU9G/oZZOUXp7ZO+28oftxKyPWbdx0Kb0ATGgR1+toZn+jw09K1zNVuD73vEVd ZotgpX3ecVt3zLi80U2bDdTMJF3Io/88A250ScZkkzuOSmPVVvDphBwTO7QQVPmZeYqNynO9n kNBBU82PNVD/Xk0D2UUdKcRKBJZ+z3Os5xluJImpX20nVK+kQPOprGr4IsBQ= X-Rspamd-Queue-Id: 47sLrf4tGqz3FF6 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2020 05:43:15 -0000 On Tue, 7 Jan 2020 05:33:33 +0000 (UTC) Mateusz Guzik wrote: > Author: mjg > Date: Tue Jan 7 05:33:33 2020 > New Revision: 356437 > URL: https://svnweb.freebsd.org/changeset/base/356437 > > Log: > procstat: read lo_name instead of now removed v_tag > > Modified: > head/lib/libprocstat/libprocstat.c > > Modified: head/lib/libprocstat/libprocstat.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > --- head/lib/libprocstat/libprocstat.c Tue Jan 7 04:34:29 2020 > (r356436) +++ head/lib/libprocstat/libprocstat.c Tue Jan 7 05:33:33 > 2020 (r356437) @@ -1278,10 +1278,10 @@ > procstat_get_vnode_info_kvm(kvm_t *kd, struct filestat vn->vn_type =3D > vntype2psfsttype(vnode.v_type); if (vnode.v_type =3D=3D VNON || vnode.v_= type =3D=3D > VBAD) return (0); > - error =3D kvm_read_all(kd, (unsigned long)vnode.v_tag, tagstr, > - sizeof(tagstr)); > + error =3D kvm_read_all(kd, (unsigned > long)vnode.v_lock.lock_object.lo_name, > + tagstr, sizeof(tagstr)); > if (error =3D=3D 0) { > - warnx("can't read v_tag at %p", (void *)vp); > + warnx("can't read lo_name at %p", (void *)vp); > goto fail; > } > tagstr[sizeof(tagstr) - 1] =3D '\0'; > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" This commit makes buildworld to fail: [...] =2D-- lib/libprocstat__L --- /usr/src/lib/libprocstat/libprocstat.c:848:2: warning: variable 'files' is= used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~~~~~ /usr/src/lib/libprocstat/libprocstat.c:851:6: note: uninitialized use occu= rs here if (files =3D=3D NULL && errno !=3D EPERM) { ^~~~~ /usr/src/lib/libprocstat/libprocstat.c:827:32: note: initialize the variab= le 'files' to silence this warning struct kinfo_file *kif, *files; ^ =3D NULL /usr/src/lib/libprocstat/libprocstat.c:1281:48: error: no member named 'v_= tag' in 'struct vnode' [...] Kind regards, oh