From owner-svn-src-head@FreeBSD.ORG Wed Nov 5 00:48:47 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A85CC106568D; Wed, 5 Nov 2008 00:48:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 47FA98FC08; Wed, 5 Nov 2008 00:48:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id mA50mdAk005785; Tue, 4 Nov 2008 19:48:41 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Ivan Voras" Date: Tue, 4 Nov 2008 17:50:08 -0500 User-Agent: KMail/1.9.7 References: <200811041904.mA4J41dL005103@svn.freebsd.org> <9bbcef730811041422x5f1e7bfco45380390c64b3b1c@mail.gmail.com> In-Reply-To: <9bbcef730811041422x5f1e7bfco45380390c64b3b1c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811041750.08355.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 04 Nov 2008 19:48:41 -0500 (EST) X-Virus-Scanned: ClamAV 0.93.1/8568/Tue Nov 4 13:53:00 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184652 - in head/sys: dev/hwpmc fs/procfs kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2008 00:48:47 -0000 On Tuesday 04 November 2008 05:22:47 pm Ivan Voras wrote: > 2008/11/4 John Baldwin : > > Author: jhb > > Date: Tue Nov 4 19:04:01 2008 > > New Revision: 184652 > > URL: http://svn.freebsd.org/changeset/base/184652 > > > > Log: > > Remove unnecessary locking around vn_fullpath(). The vnode lock for the > > Does this affect realpath(3)? (whose non-scalability is often reported > for PHP web servers). realpath(3) calls getcwd(3) (which devolves to __getcwd(2) I think) once per invocation (and that already did not lock the vnode). It then calls lstat() for each component in the path. The lstat() calls should be using shared locks (at least with the recent changes to use shared lookups for UFS in HEAD). I imagine the bottleneck is more with lstat() than getcwd(3). Neither is helped by the specific changes above. -- John Baldwin