Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jun 2014 03:47:24 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Mikhail Teterin <mi@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r357218 - head/print/rlpr
Message-ID:  <20140610014723.GO73493@ivaldir.etoilebsd.net>
In-Reply-To: <201406092300.s59N0sov088281@svn.freebsd.org>
References:  <201406092300.s59N0sov088281@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--qse+WBH4guesipZ+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 09, 2014 at 11:00:54PM +0000, Mikhail Teterin wrote:
> Author: mi
> Date: Mon Jun  9 23:00:54 2014
> New Revision: 357218
> URL: http://svnweb.freebsd.org/changeset/ports/357218
> QAT: https://qat.redports.org/buildarchive/r357218/
>=20
> Log:
>   Support staging. (Still don't understand, why the MANs-knobs had to
>   go...)
>=20
> Modified:
>   head/print/rlpr/Makefile
>=20
> Modified: head/print/rlpr/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/print/rlpr/Makefile	Mon Jun  9 22:59:54 2014	(r357217)
> +++ head/print/rlpr/Makefile	Mon Jun  9 23:00:54 2014	(r357218)
> @@ -17,7 +17,6 @@ LICENSE=3D	GPLv2
>  GNU_CONFIGURE=3D	yes
>  # rlpr supports gettext/libintl, but does not currently come with ANY
>  # translation .po files. When this changes, it would make sense to
> -NO_STAGE=3D	yes
>  # enable the use of gettext in this port:
>  #USES=3D	gettext
>  #CONFIGURE_ENV=3D	CPPFLAGS=3D"-I${PREFIX}/include" LDFLAGS=3D"-L${PREFIX=
}/lib -lintl"
> @@ -32,11 +31,12 @@ post-patch:
> =20
>  post-install:
>  	# Making the installed binaries suid,\
> -		      for the remote lpds to talk to them"
> -	${CHMOD} 4555 ${PREFIX}/bin/rlpq ${PREFIX}/bin/rlpr ${PREFIX}/bin/rlprm
> +		      for the remote lpds to talk to them
> +	${CHMOD} 4555 ${STAGEDIR}${PREFIX}/bin/rlpq	\
> +		${STAGEDIR}${PREFIX}/bin/rlpr	\
> +		${STAGEDIR}${PREFIX}/bin/rlprm
> =20
> -MAN1=3D	rlpr.1 rlpq.1 rlprm.1
> -MAN5=3D	rlprrc.5
> -MAN8=3D	rlprd.8
> +PLIST_FILES+=3D	man/man1/rlpq.1.gz man/man1/rlpr.1.gz man/man1/rlprm.1.g=
z \
> +		man/man5/rlprrc.5.gz man/man8/rlprd.8.gz
> =20
>  .include <bsd.port.mk>
>=20

Because it was wrong, badly handling with what needs to be compressed and n=
ot
properly handling automatic compression etc, the new system is way simple w=
hile
properly handling compression and links (sym or hard) automatically. It is =
also
consistent over ports. this could not have been done without killing the MA=
N*
macros.

Bapt

--qse+WBH4guesipZ+
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iEYEARECAAYFAlOWY6sACgkQ8kTtMUmk6EzgqgCeIew+8nqzKOuLy6iDDhlP2JIi
ipIAoLaTA5fcmNJi8KkDD7xxNDlaLvv5
=62pp
-----END PGP SIGNATURE-----

--qse+WBH4guesipZ+--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140610014723.GO73493>