From owner-freebsd-hackers Wed Feb 7 06:37:31 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA02569 for hackers-outgoing; Wed, 7 Feb 1996 06:37:31 -0800 (PST) Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id GAA02562 for ; Wed, 7 Feb 1996 06:37:28 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by Root.COM (8.6.12/8.6.5) with SMTP id GAA09119; Wed, 7 Feb 1996 06:37:35 -0800 Message-Id: <199602071437.GAA09119@Root.COM> X-Authentication-Warning: implode.Root.COM: Host localhost didn't use HELO protocol To: Julian Elischer cc: hackers@freebsd.org Subject: Re: TERRY patches.. In-reply-to: Your message of "Wed, 07 Feb 1996 03:18:02 PST." <199602071118.DAA00521@ref.tfs.com> From: David Greenman Reply-To: davidg@Root.COM Date: Wed, 07 Feb 1996 06:37:35 -0800 Sender: owner-hackers@freebsd.org Precedence: bulk >I think we would gain more by leaving the existing code "As IS" >and inserting 4-line comment groups every clause, explaining what's going on.. >I think 'cosmetic reworks' should be avoided, as it tends to: >1/ make it harder to merge/compare code >2/ obfuscate the real nature of the change. Please _don't_ commit the changes in their current form. At this particular point in time, cosmetic changes in the FS area must be avoided at all costs. >From a purely architectural standpoint, many of Terry's personal-taste/style changes are very inappropriate. After all, it is us (me in particular :-)) that will have to maintain this stuff in the years ahead. I'm not interested in debating this. I don't have any time to review the changes right now. I'm headed to the airport shortly for a meeting in San Francisco and I might be gone for several days if we decide to move wcarchive to a new location. -DG David Greenman Core Team/Principal Architect, The FreeBSD Project