From owner-freebsd-stable@FreeBSD.ORG Sat Aug 16 09:46:28 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C65B337B401; Sat, 16 Aug 2003 09:46:28 -0700 (PDT) Received: from grosbein.pp.ru (D00015.dialonly.kemerovo.su [213.184.66.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3456243FB1; Sat, 16 Aug 2003 09:46:25 -0700 (PDT) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (eugen@localhost [127.0.0.1]) by grosbein.pp.ru (8.12.9/8.12.9) with ESMTP id h7GGkKah001229; Sun, 17 Aug 2003 00:46:20 +0800 (KRAST) (envelope-from eugen@grosbein.pp.ru) Received: (from eugen@localhost) by grosbein.pp.ru (8.12.9/8.12.9/Submit) id h7GGkJCm001228; Sun, 17 Aug 2003 00:46:19 +0800 (KRAST) Date: Sun, 17 Aug 2003 00:46:19 +0800 From: Eugene Grosbein To: Doug White Message-ID: <20030817004619.A1179@grosbein.pp.ru> References: <20030815211321.A11482@grosbein.pp.ru> <20030815191010.S16351@carver.gumbysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20030815191010.S16351@carver.gumbysoft.com>; from dwhite@gumbysoft.com on Fri, Aug 15, 2003 at 07:13:57PM -0700 cc: stable@freebsd.org cc: bug-followup@freebsd.org Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2003 16:46:29 -0000 On Fri, Aug 15, 2003 at 07:13:57PM -0700, Doug White wrote: > You should not remove the ifdef and change the indentation of deljob. Just > s/del/free and be done with it :-) I highly doubt anyone needs to disable > job control in sh, but in the off chance they do, you might as well keep > the ifdef around. > > Note that freejob calls deljob. That's why I've removed #ifdef. freejob() already has these #ifdefs around deljob(). However, freejob() is not wrapped with #ifdefs itself. So I've removed them here. Identation is my fault. Eugene Grosbein