From owner-freebsd-arch@freebsd.org Wed Aug 7 20:14:53 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8BBDBB663E for ; Wed, 7 Aug 2019 20:14:53 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 463jR03lS2z4GwB for ; Wed, 7 Aug 2019 20:14:52 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7F96522022 for ; Wed, 7 Aug 2019 16:14:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 07 Aug 2019 16:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=dQh3nAkJc1evcwMAGC9kr1RRAOZ y21bZZbJ/eFlY4ZI=; b=JCiIkH74bSx6vKCOEDWEeJZYssH8gFeB3ZAKI64XJ0v V3mmaAS92f0auKPcXAmLp2YHMYK3XkBrBj4ykplkRgthwcx9zrFth+XOgx0iOg7E ufegWGnMkLJElgwX4aconYE/TPmsltq6YAqKTRiaVyfpRRxEMJUtl4Cstyj4Aatf g+MVM7uhL4Aho0NNwDxQYwa11IJSSMT5Yl+V7b5koYJ1syAvkbnC472bmo1tZmxh jsHvstPgqsZTfVw1dRQGHRZpI6wTSNtWC9vnF8RLe0XVHRgiXHSaZ+5GX3V2u1/9 Xg7IwQypL2+xEOQZtOTBqqsQn7jqI/t1bBumw9MPJPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=dQh3nA kJc1evcwMAGC9kr1RRAOZy21bZZbJ/eFlY4ZI=; b=LwGMphsteSBJIAnShbUiiH IU6chMxNcinBiWodIU2k0lhWL7L59z6xc+gyloctIpU9i2vvlnexp2XJVrNVYfUD LCnK3v6iKcl+OflXIuynoFOAbcPlu2CBzmlJCYflNjmCh4nrxjurQEqdXVO7JPI9 33Hea8tfPF9nspzIDRBn1Wpa6xQVl+MiY4hic5eNy++VUmgI+umhBq31hGDCLpO3 qU09e86lLV2QsVmTuf8t1cKoOaksP01fM9myFRkaV2mtTv7Eyq+MYgxv+3D7EbxR 94F0oalUeSgU/xULkdwpeofpwFSuX5L4nwaaEnN3Wd97NRCjRzIy1xYIy5PNWPPw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduvddgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesgh dtreertdervdenucfhrhhomhepthgvtghhqdhlihhsthhsuceothgvtghhqdhlihhsthhs seiihiigshhtrdhnvghtqeenucfkphepkedvrdejtddrledurdelleenucfrrghrrghmpe hmrghilhhfrhhomhepthgvtghhqdhlihhsthhsseiihiigshhtrdhnvghtnecuvehluhhs thgvrhfuihiivgeptd X-ME-Proxy: Received: from bastion.zyxst.net (unknown [82.70.91.99]) by mail.messagingengine.com (Postfix) with ESMTPA id 42465380074 for ; Wed, 7 Aug 2019 16:14:50 -0400 (EDT) Date: Wed, 7 Aug 2019 21:14:48 +0100 From: tech-lists To: freebsd-arch@freebsd.org Subject: Re: svn commit: r350550 - head/share/mk Message-ID: <20190807201448.GA42725@bastion.zyxst.net> References: <201908030106.x7316Ibx078529@repo.freebsd.org> <20190806165614.GA41295@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline In-Reply-To: <20190806165614.GA41295@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 463jR03lS2z4GwB X-Spamd-Bar: --------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=zyxst.net header.s=fm3 header.b=JCiIkH74; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=LwGMphst; dmarc=none; spf=pass (mx1.freebsd.org: domain of tech-lists@zyxst.net designates 66.111.4.25 as permitted sender) smtp.mailfrom=tech-lists@zyxst.net X-Spamd-Result: default: False [-9.15 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[zyxst.net:s=fm3,messagingengine.com:s=fm3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.25]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[zyxst.net]; DKIM_TRACE(0.00)[zyxst.net:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.999,0]; SIGNED_PGP(-2.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[25.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-3.45)[ip: (-9.69), ipnet: 66.111.4.0/24(-4.81), asn: 11403(-2.68), country: US(-0.05)] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2019 20:14:53 -0000 --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Tue, Aug 06, 2019 at 04:56:14PM +0000, Glen Barber wrote: >I would like to request this commit be reverted. While the original >commit message to enable this knob stated the commit would be reverted >after stable/12 branched, I have seen no public complaints about >enabling REPRODUCIBLE_BUILD by default (and quite honestly, do not see >the benefit of disabling it by default -- why wouldn't we want >reproducibility?). > >To me, this feels like a step backwards, with no tangible benefit. >Note, newvers.sh does properly detect a modified tree if it can find >the VCS metadata directory (i.e., .git, .svn) -- I know this because >I personally helped with it. > >In my opinion, those that want the non-reproducible metadata included in >output from 'uname -a' should set WITHOUT_REPRODUCIBLE_BUILDS in their >src.conf. Turning off a sane default for the benefit of what I suspect >is likely a short list of use cases feels like a step in the wrong >direction. Well, my use case is that I have some machines that follow 12-stable. I'm not a developer. But I keep an eye on things like security bulletins etc and when they come out it usually gives something like 'affecting 12-STABLE prior to r something like that. And I can easily look at uname -a to see if this or that 12-stable machine needs to be patched or whatever. That is, if reproductible_build is turned off. (or without_reproductible_build is turned on)=20 Or if I mail to stable@ asking for help I'll want to say *exactly* what sources I've built from. And sometimes someone will say "oh that was fixed after r" and so I'll grab sources after that revision=20 if I can and fix the problem. But like I say I'm not a dev. I'd guess, though, that lots of non-devs=20 use the revision info if they follow -stable, so if I'm right in thinking= =20 this, it'd be a short list of use cases but lots of affected people. unless there's another way to get the svn rev number? Why turn off this functionality by default? --=20 J. --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8n3tWhxW11Ccvv9/s8o7QhFzNAUFAl1LMSMACgkQs8o7QhFz NAU4xBAAh8VrhAoR/9icuzCvBWyh8KAAgrIZEbBM+qXyRDI0bDD41U3r1XRGfuKo 7/3TvaJipRhtXv0VPRdo495Plq9gUX/9uQzoMsd7p0gtZ/4zqu8/+hMrERcwPsrl m9V3upO0J9bVycQb7Wl0jYqPIkttoTa/Jzm/enqJLFCfa29igakOn5Xx9Y/HeCUw chd7I2jm7cwXqz6M7kzt4N+AeR5Cee1LVTfrfWWs8S9nuJMxR1giI1jHrJvpeATn SPk9FhBCKZq0YjXI4RWY9iM2R+PaXz5+VuAdyW58ksCXDL1XY2q0aT0YiVh7lQRP QFNblzjJXAH7dSBlgdWp3KS0aZ0OEd8+fnA0WFU+xuIOrBdF1YLv/l38HXQ1eSOn Phf665cLqPwlJGW+kNUyEaFs1d+MbPsfsiM9FGxC8wAYsVESVTbeE7qioytoyd4Z 7MvBVgqXZw6iIFWXeBYabT4MPlsLvRn0YXWUr1fuINfPN5GsnEvd56cQnipv11tG hTAEe4hIzaKq7gZywaqJshQGb86fHHv/GqJ85Um4fqFqPOubdg1W3a1XcCnpMxDG EPiYCGhbgrOXKYKJF869NSjOv+lBVUHuchm1FRhLqO2kngL84qdHgOTP/WKFbgLh l2E4bhP4KaSj48GmzyedBT3PKjLrqp+Xg1t2/4waDNPxDeefZQU= =CYHZ -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1--