From owner-freebsd-ports@FreeBSD.ORG  Sat Feb 20 21:51:09 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88EE9106568D
	for <ports@freebsd.org>; Sat, 20 Feb 2010 21:51:09 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.50.215])
	by mx1.freebsd.org (Postfix) with ESMTP id 65B628FC14
	for <ports@freebsd.org>; Sat, 20 Feb 2010 21:51:09 +0000 (UTC)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id 693C45C4C; Sat, 20 Feb 2010 16:51:08 -0500 (EST)
Date: Sat, 20 Feb 2010 16:51:08 -0500
From: Wesley Shields <wxs@FreeBSD.org>
To: Christer Solskogen <christer.solskogen@gmail.com>
Message-ID: <20100220215108.GC66609@atarininja.org>
References: <c1a0d1561002200755q4ab28515ic550fca1789e1cd8@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c1a0d1561002200755q4ab28515ic550fca1789e1cd8@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: ports@freebsd.org
Subject: Re: make package-noinstall does not include rc.d scripts?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Feb 2010 21:51:09 -0000

On Sat, Feb 20, 2010 at 04:55:58PM +0100, Christer Solskogen wrote:
> Hi!
> 
> I've just discovered the make option "make package-noinstall" which
> makes a tbz in /usr/ports/packages from a already installed package.
> But I've also found a bug(?) with that option. The package it creates
> seems not to include rc.d script which will be included if you use
> "make package"
> I've tried this now with two ports (stunnel and mysql51-server) - but
> I guess that it will happen to other ports as well.

I tested it with devel/git and it looks like a bug to me. I've got a
patch which should fix it[1]. It's basically a copy/paste of the
install-rc-script target into the do-package target and removing the two
lines that actually install the script.

A better solution may be to have one target install the rc script and
one target add it to the plist. That way the add-to-plist target can be
effectively shared. Minimizing the chances that changes in one do not
reflect into the other.

Does anyone have any opinions on this? If not I'll open a PR for
portmgr.

[1]: http://people.freebsd.org/~wxs/package-noinstall-rc-script.diff

-- WXS