From owner-freebsd-ports Wed Sep 5 7:27:45 2001 Delivered-To: freebsd-ports@freebsd.org Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by hub.freebsd.org (Postfix) with ESMTP id 80FAA37B405; Wed, 5 Sep 2001 07:27:37 -0700 (PDT) Received: from vega.vega.com (dialup9-27.iptelecom.net.ua [212.9.228.27]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id RAA43005; Wed, 5 Sep 2001 17:27:15 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.4/8.11.3) with ESMTP id f85EQ2o03702; Wed, 5 Sep 2001 17:26:02 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3B963646.F285276E@FreeBSD.org> Date: Wed, 05 Sep 2001 17:27:18 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.78 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Mikhail Teterin Cc: obrien@FreeBSD.org, ache@nagual.pp.ru, ru@FreeBSD.org, ports@FreeBSD.org, kris@obsecurity.org Subject: Re: cvs commit: src/lib/libc/stdlib strtol.c strtoll.c strtoq.c strtoul.c strtoull.c strtouq.c References: <200109051334.f85DY7o63331@aldan.algebra.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Mikhail Teterin wrote: > On 5 Sep, Maxim Sobolev wrote: > > >> BTW, most of the patches in the ports-tree don't have such IDs, but > >> some do. Since those IDs are discarded as early as at the "make > >> patch" stage, I think they are pretty useless -- they don't make it > >> to the compiled binaries anyway. But what's the general opinion? > > > No, they are pretty useful, IMO. When the user has a problem you can > > verify version of patches he has and after the problem is resolved > > tell him "update patxh-xx to the rev.Y.X and you'll be fine". > > Can't we use the version strings of the ports' Makefiles? They are > supposed to be in sync with the patches. Anyway, you don't say "update X > to rev Y". You say: "update to the latest version of the port" -- > nothing but the whole port, and no other version, but the latest one. > > Besides, you can always simply look at the timestamp of the patch. The > usefullness of the rcs (and other) ids in the sources, is that they let > the ids make it into the binaries, where they can be read by ident(1) > and similar tools. Ids in patch files don't make into the binaries... This is an oversimplistic view. Ids in many files in our src tree don't go into binaries (think about header files). -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message