From owner-freebsd-current Tue Jul 2 21:17:22 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28C7937B400 for ; Tue, 2 Jul 2002 21:17:19 -0700 (PDT) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id A965443E0A for ; Tue, 2 Jul 2002 21:17:18 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 25136 invoked from network); 3 Jul 2002 04:17:16 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 3 Jul 2002 04:17:16 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g634HFM24496; Wed, 3 Jul 2002 00:17:15 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <15650.26618.523781.562050@grasshopper.cs.duke.edu> Date: Wed, 03 Jul 2002 00:17:23 -0400 (EDT) From: John Baldwin To: Andrew Gallatin Subject: Re: KSE signal problems still Cc: freebsd-current@freebsd.org, Julian Elischer Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 03-Jul-2002 Andrew Gallatin wrote: > > Julian Elischer writes: > > > > > > However, it does seem a bit silly, as we end up dropping > > > and-reaquiring the sched lock quite a few times: > > > > That's why I just asked you to test the concept.. > > If I know that just aquiring it here is ok, > > (I presume you tried doing some work like this) > > that tells me that this code isn't called from some odd place, > > with the sched lock already set. > > > > (that and code inspection of course..) > > > > Now we know it works we can try optimise it.. > > > > I'm going home now for dinner, > > so if you feel like checking this or something mor optimal in, > > be my guest :-) > > OK, I've checked in the unoptimized fix. Please do optimize it when > you get a chance. Erm, I thought I changd signotify() to require sched_lock and made the second half of psignal() (the whole case statement) lock sched_lock. Did you change that? (To Julian) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message