From owner-cvs-all Tue Jul 24 0: 9:49 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [206.40.252.115]) by hub.freebsd.org (Postfix) with ESMTP id 70B9437B405; Tue, 24 Jul 2001 00:09:45 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f6O79c859309; Tue, 24 Jul 2001 00:09:38 -0700 (PDT) (envelope-from obrien) Date: Tue, 24 Jul 2001 00:09:38 -0700 From: "David O'Brien" To: Garance A Drosihn Cc: Greg Lehey , Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/atrun atrun.c Message-ID: <20010724000938.C49187@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200107231205.f6NC5R526236@freefall.freebsd.org> <200107231103.f6NB3mi10592@freefall.freebsd.org> <200107231100.f6NB0Wm05549@freefall.freebsd.org> <20010724090813.M55779@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from drosih@rpi.edu on Mon, Jul 23, 2001 at 09:30:44PM -0400 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jul 23, 2001 at 09:30:44PM -0400, Garance A Drosihn wrote: > If you are questioning the log message, then the issue is "What > are log messages for?". The log message is supposed to give a > short but informative summary of what the change is. Not fully. Much more important (since I can do `cvs diff' if I really want to see the "what") is the _why_. In many cases the _why_ is obvious. But in many it is 100% apparent _why_ to the committer, but really no one else (including the committer) 6mo., 1 yr, 5 years later. > These log messages are informative, and it's hard to imagine how they > could be any shorter. Sounds like a good log message to me. In these particular cases I totally agree. Grog must have caught the "very boring post-USENIX weekend" bug or something... -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message