Date: Fri, 18 May 2007 01:04:13 +0200 From: Benjamin Lutz <mail@maxlor.com> To: pav@freebsd.org Cc: ports@freebsd.org Subject: Re: make -j patch Message-ID: <200705180104.17556.mail@maxlor.com> In-Reply-To: <1179437165.8912.1.camel@ikaros.oook.cz> References: <200705171700.32126.mail@maxlor.com> <1179437165.8912.1.camel@ikaros.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1267243.lCosKnWZJc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 17 May 2007 23:26, Pav Lucistnik wrote: > Benjamin Lutz p=C3=AD=C5=A1e v =C4=8Dt 17. 05. 2007 v 17:00 +0200: > > ALLOW_MAKE_JOBS: Goes into a port's makefile. The port maintainer > > indicates with it that the port can be built with multiple make > > jobs. > > Nit: what about making this just MAKE_JOBS, for brevity? Well, all the other switches that go into a ports makefile start with a=20 verb (USE_* or WANT_*), whereas with variables that don't start with a=20 verb, their value usually matters. Since ALLOW_MAKE_JOBS is just a=20 switch, I think the ALLOW should be kept. But there's another small thing that I changed: BUILD_FAILMSG should of=20 course also be printed if Perl is used for building. And while here,=20 move the =3D=3D=3D> out of the error message and into the printf format=20 string. The file has been modified in place, so the URL is still http://www.maxlor.com/freebsd/files/make_jobs.diff The previous version, for completeness sake, is here: http://www.maxlor.com/freebsd/files/make_jobs.diff.1 Cheers Benjamin --nextPart1267243.lCosKnWZJc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGTN9xzZEjpyKHuQwRAjKqAJ4vbBi2jcVgldQYImq/Bd2S3B1J7gCfVrWf w1+7wqHFl8aviUgh4wYR5G8= =enT5 -----END PGP SIGNATURE----- --nextPart1267243.lCosKnWZJc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705180104.17556.mail>