From owner-svn-src-head@FreeBSD.ORG Wed May 30 13:51:00 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFC88106564A; Wed, 30 May 2012 13:51:00 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CB7368FC0A; Wed, 30 May 2012 13:51:00 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q4UDp0WK055462; Wed, 30 May 2012 13:51:00 GMT (envelope-from glebius@svn.freebsd.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q4UDp0wZ055460; Wed, 30 May 2012 13:51:00 GMT (envelope-from glebius@svn.freebsd.org) Message-Id: <201205301351.q4UDp0wZ055460@svn.freebsd.org> From: Gleb Smirnoff Date: Wed, 30 May 2012 13:51:00 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r236310 - head/sys/netinet X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2012 13:51:01 -0000 Author: glebius Date: Wed May 30 13:51:00 2012 New Revision: 236310 URL: http://svn.freebsd.org/changeset/base/236310 Log: Improve style(9) of bcopy() to and from mbuf tag. Submitted by: bde Modified: head/sys/netinet/ip_carp.c Modified: head/sys/netinet/ip_carp.c ============================================================================== --- head/sys/netinet/ip_carp.c Wed May 30 13:44:42 2012 (r236309) +++ head/sys/netinet/ip_carp.c Wed May 30 13:51:00 2012 (r236310) @@ -696,7 +696,7 @@ carp_prepare_ad(struct mbuf *m, struct c CARPSTATS_INC(carps_onomem); return (ENOMEM); } - bcopy(&sc, (caddr_t)(mtag + 1), sizeof(struct carp_softc *)); + bcopy(&sc, mtag + 1, sizeof(sc)); m_tag_prepend(m, mtag); return (0); @@ -1066,8 +1066,7 @@ carp_macmatch6(struct ifnet *ifp, struct /* Better a bit than nothing. */ return (LLADDR(&sc->sc_addr)); - bcopy(&sc, (caddr_t)(mtag + 1), - sizeof(struct carp_softc *)); + bcopy(&sc, mtag + 1, sizeof(sc)); m_tag_prepend(m, mtag); return (LLADDR(&sc->sc_addr)); @@ -1391,7 +1390,7 @@ carp_output(struct ifnet *ifp, struct mb if (mtag == NULL) return (0); - bcopy(mtag + 1, &sc, sizeof(struct carp_softc *)); + bcopy(mtag + 1, &sc, sizeof(sc)); /* Set the source MAC address to the Virtual Router MAC Address. */ switch (ifp->if_type) {