Date: Mon, 19 Apr 2004 23:23:09 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Kirill Ponomarew <krion@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/pnet-base Makefile ports/lang/pnetlib Makefile Message-ID: <20040420062308.GA54233@xor.obsecurity.org> In-Reply-To: <200404200559.i3K5xVfh058842@repoman.freebsd.org> References: <200404200559.i3K5xVfh058842@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 19, 2004 at 10:59:31PM -0700, Kirill Ponomarew wrote: > krion 2004/04/19 22:59:31 PDT >=20 > FreeBSD ports repository >=20 > Modified files: > lang/pnet-base Makefile=20 > lang/pnetlib Makefile=20 > Log: > - Fix IGNORE message > - Remove quotes > | .if ${ARCH} =3D=3D "alpha" > | -BROKEN=3D "cscc core dumps" > | +BROKEN=3D Coredump during build on alpha > | .endif For these examples it was academic since they don't contain special characters, but when they do then BROKEN needs to be quoted, and IGNORE needs to be *not* quoted (because it is quoted internally by bsd.port.mk). I tried to repair this inconsistency a few weeks ago because people (including myself) keep getting it wrong, but it was hard to get all the cases to work and I haven't come back to it yet. In the meantime it might be better to just remove all quotes from IGNORE strings. > | .if ${ARCH} =3D=3D "alpha" > | -IGNORE=3D "cscc core dumps durring build" > | +IGNORE=3D Coredump during build on alpha > | .endif My point here was that IGNORE does this: =3D=3D=3D> pnetlib-0.6.4 Coredump during build on alpha. which is not a properly formed sentence. Kris --J/dobhs11T7y2rNN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAhMHMWry0BWjoQKURAmU+AJ9jDulJmfDOSZSGKUb+MzzrAxPfIQCg3t5b gF66wKrTS8wJXtPlvY5VdAU= =C4zb -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040420062308.GA54233>