From nobody Sun Jan 21 00:30:55 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4THZ5l5gs4z57rYS; Sun, 21 Jan 2024 00:31:07 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Received: from symbion.zaytman.com (symbion.zaytman.com [64.112.176.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "symbion", Issuer "Narawntapu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4THZ5l44CJz44Qd; Sun, 21 Jan 2024 00:31:07 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Authentication-Results: mx1.freebsd.org; none Received: from aldan.narawntapu (pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187]) by symbion.zaytman.com (8.17.1/8.16.1) with ESMTPS id 40L0V2qn051047 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sat, 20 Jan 2024 19:31:04 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: symbion.zaytman.com: Host pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187] claimed to be aldan.narawntapu Received: from [192.168.1.10] (aldan [192.168.1.10]) by aldan.narawntapu (8.17.2/8.17.1) with ESMTP id 40L0UtDX032207; Sat, 20 Jan 2024 19:30:56 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: aldan.narawntapu: Host aldan [192.168.1.10] claimed to be [192.168.1.10] Content-Type: multipart/alternative; boundary="------------Gn05ibThosslzv8oYJUWh40I" Message-ID: Date: Sat, 20 Jan 2024 19:30:55 -0500 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple To: Daniel Engberg Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> Content-Language: en-US From: "Mikhail T." In-Reply-To: X-DCC-www.nova53.net-Metrics: aldan.narawntapu 1204; bulk rep Body=4 Fuz1=4 Fuz2=4 rep=43% X-Spam-Status: No, score=-2.8 required=23.7 tests=ALL_TRUSTED,BAYES_00, HTML_MESSAGE,TW_KG,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on aldan.narawntapu X-Rspamd-Queue-Id: 4THZ5l44CJz44Qd X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[t]; ASN(0.00)[asn:394548, ipnet:64.112.176.0/24, country:US] This is a multi-part message in MIME format. --------------Gn05ibThosslzv8oYJUWh40I Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 20.01.24 17:15, Daniel Engberg: > Please at least enable DEVELOPER=yes and fix any warnings Why? How would that help anything? > Use the standard definition for POSTGRES, PGSQL > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410 Ok, I renamed the option. But the description is still port-specific... > SQLITE option is broken > "post-patch-SQLIT3-off" Ah, thanks! > > Overall ordering in Makefile can be improved portlint only mentions the patch being manually created... > LDFLAGS can probably be replaced with USES= localbase:ldflags Indeed! > > Configure logs suggests that USES= pkgconfig should be added Neah. Upstream's cmake-file tries to use pkgconfig to find libpurple. But it does not work anyway -- and the port supplies definitions for all the of the relevant cmake variables. > > It also fails to build > > https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log > So it does... But the failure is not due to anything you mentioned, but because of go's inability to download the additional modules, that the software wants: go: finding module for package go.mau.fi/whatsmeow/store github.com/hoehermann/purple-gowhatsapp/src/go imports github.com/alfg/mp4: module github.com/alfg/mp4: Get"https://proxy.golang.org/github.com/alfg/mp4/@v/list": dial tcp: lookup proxy.golang.org on 199.115.205.169:53: write udp 127.0.0.1:54689->199.115.205.169:53: write: permission denied Perhaps, that's because downloading during build is a no-no... I did e-mail maintainers of the Uses/go.mk last night seeking suggestions about this. There was no reply, so I decided to commit it -- and asked for help. Which helping would be easier, if the helper(s) could just commit an improvement... > If you're unsure please consider to create a review / PR instead of > just committing. Sorry, but what's the difference? Was Production Support woken up somewhere by a Level-1 alert due to the build-failure? > Please back this out for now.  The only good reason to back out a change is when it breaks something else. Which this one didn't...  I'll try to fix it, of course -- and if someone can help me with predownloading the Go-modules, that'd be great (Maven-using ports must dealing with that somehow...) But why would you want it backed out?! -mi --------------Gn05ibThosslzv8oYJUWh40I Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
20.01.24 17:15, Daniel Engberg:
Please at least enable DEVELOPER=yes and fix any warnings


Why? How would that help anything?

Use the standard definition for POSTGRES, PGSQL

Ok, I renamed the option. But the description is still port-specific...

SQLITE option is broken
"post-patch-SQLIT3-off"
Ah, thanks!

Overall ordering in Makefile can be improved
portlint only mentions the patch being manually created...
LDFLAGS can probably be replaced with USES= localbase:ldflags
Indeed!

Configure logs suggests that USES= pkgconfig should be added
Neah. Upstream's cmake-file tries to use pkgconfig to find libpurple. But it does not work anyway -- and the port supplies definitions for all the of the relevant cmake variables.

It also fails to build


So it does... But the failure is not due to anything you mentioned, but because of go's inability to download the additional modules, that the software wants:

go: finding module for package go.mau.fi/whatsmeow/store
github.com/hoehermann/purple-gowhatsapp/src/go imports
	github.com/alfg/mp4: module github.com/alfg/mp4: Get "https://proxy.golang.org/github.com/alfg/mp4/@v/list": dial tcp: lookup proxy.golang.org on 199.115.205.169:53: write udp 127.0.0.1:54689->199.115.205.169:53: write: permission denied

Perhaps, that's because downloading during build is a no-no... I did e-mail maintainers of the Uses/go.mk last night seeking suggestions about this. There was no reply, so I decided to commit it -- and asked for help. Which helping would be easier, if the helper(s) could just commit an improvement...

If you're unsure please consider to create a review / PR instead of just committing.
Sorry, but what's the difference? Was Production Support woken up somewhere by a Level-1 alert due to the build-failure?
Please back this out for now.

 The only good reason to back out a change is when it breaks something else. Which this one didn't...

 I'll try to fix it, of course -- and if someone can help me with predownloading the Go-modules, that'd be great (Maven-using ports must dealing with that somehow...)

But why would you want it backed out?!

-mi

--------------Gn05ibThosslzv8oYJUWh40I--