From nobody Tue Jul 15 16:40:18 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bhQ0P34Qjz62ZMS; Tue, 15 Jul 2025 16:40:21 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bhQ0P1Q31z44V8; Tue, 15 Jul 2025 16:40:21 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752597621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b909/FG0c/6//YI34T8ZqupsD6hqr5bH2wxiChU5hc=; b=Ai14vX2yOE5hGf1XY2KGOWAOlUrCmUL7InATcDoXqr61NWvIdnGt5aSFlIiLCj/PpX4Dix VSK9F+8KIiX6FfWebxdWbvUyF3X/xa23PfP32AO3xriY0jB4DTCpCvXa0qBFJa6Q1hHro0 Jsgs388Vws3xXn7Z0/9gz36sCv3zDRWiKQrxZaxpHp8UKNpRnHEfykFFEj76S/7KSNcscJ YslwzdCWS9Mi0N6pSk4h1j+X8eiz9aRQmzjQgAkiel4w9z6BXRCme9IXURIUb8/yp6BQrL ujhLiW+7LzexqeLeWmVgU4fjm3GIfQcOv+CqBVG8zcA6sf/g06oNNWxFB7vQrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752597621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b909/FG0c/6//YI34T8ZqupsD6hqr5bH2wxiChU5hc=; b=tX44q75muODsNYMWgXrEVUvToqSsGl6xSt/u4BW8DWzL1bUbi3cDTshKOYkRkWa26Ey2JK p6pa58dGD+uzHlesmL6QPVQPPxEI06IGgKyl87gs91qAoJToVQzm+5BTRm8Em3Cm0co+wQ 9ZClcwTQlzCeOW3xnH8HOeDRwEQ5ctvUHcP97zDkmWYLlLdyN3Wshj3vKwt08nCoyxBssL Am/awuuDSXth49T5mxhTS4nbyutcXIDIatcrR7TWphD69X9jo+F9DmvJEF6jiA2X9nr6ud khsJ0H/Iu0tl4HkYuIP99KdWmt5ew8xFLDhmMRKSkPf5YasUjxGv/NpIzCwtoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752597621; a=rsa-sha256; cv=none; b=GvNRvsNh5HYZIy+DZWVdzDcSrheHXcnDNAOigKKq4vOs5RSOjkvmQDgkbzzSJEwFTNg7Dm H4bDSKlE+WvArfxS3xpH6Eo+TrXNlXsPPoUbPWyVW+P/gMkGDsCseS5NamyoIpOV+/AADy RDPRkrfN72FI8MhPuYuTUuGewbUTUGi46LXczoJ52r6v+dOZlwHqSBUXtqLbyo8cMuI6JR Cd06YFt61QZrK1gHVjSO3UNzEn91qwEZ+d1KuxmJZy87UUUOiXuzoofRbU+xWDIUolObrO xLQoOmhxdPTTPAiQ2tmgGSmnFTmYd7U6fr7KO7ib7LRnvGuEHYlzZRSOvLaqGg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bhQ0N27P4zHC7; Tue, 15 Jul 2025 16:40:20 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 15 Jul 2025 09:40:18 -0700 From: Gleb Smirnoff To: Mark Johnston , alc@freebsd.org, kib@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fad79db40505 - main - vm_pageout: Remove a volatile qualifier from some vm_domain members Message-ID: References: <202507151519.56FFJ4FS013944@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202507151519.56FFJ4FS013944@gitrepo.freebsd.org> On Tue, Jul 15, 2025 at 03:19:04PM +0000, Mark Johnston wrote: M> The branch main has been updated by markj: M> M> URL: https://cgit.FreeBSD.org/src/commit/?id=fad79db405052f3faad7184ea2c8bfe9f92a700d M> M> commit fad79db405052f3faad7184ea2c8bfe9f92a700d M> Author: Mark Johnston M> AuthorDate: 2025-07-15 15:16:40 +0000 M> Commit: Mark Johnston M> CommitDate: 2025-07-15 15:16:40 +0000 M> M> vm_pageout: Remove a volatile qualifier from some vm_domain members M> M> These are always accessed using atomic(9) intrinsics, so do not need the M> qualifier. No functional change intended. M> M> Reviewed by: alc, kib M> MFC after: 2 weeks M> Sponsored by: Modirum MDPay M> Sponsored by: Klara, Inc. M> Differential Revision: https://reviews.freebsd.org/D51322 What's the benefit of removing the qualifiers? They act as documentation and they match atomic(9) prototypes. To me this looks like removing a const qualifier with a reasoning that we use the variable only as an argument to functions that have const qualifier. -- Gleb Smirnoff