Date: Tue, 30 Aug 2016 16:18:54 +0200 From: Mathieu Arnold <mat@freebsd.org> To: marino@freebsd.org, =?UTF-8?B?UGF3ZcWCIFDEmWthbGE=?= <pawel@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420924 - head/audio/gmpc-magnatune Message-ID: <985bc855-dbed-bd5f-bc2b-d5df6e251890@mat.cc> In-Reply-To: <71f7c7a0-d2f3-9463-f769-0eb499d4701e@marino.st> References: <201608261504.u7QF46B1060800@repo.freebsd.org> <074eb0ed-40bb-e188-4754-3edde192db12@marino.st> <8fe3e649-e929-c037-6193-c23b685a1222@marino.st> <20160830150544.4f57349e@FreeBSD.org> <71f7c7a0-d2f3-9463-f769-0eb499d4701e@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lr8ddm2Pnd20J1D06HawB3aqX7wgPm2nQ Content-Type: multipart/mixed; boundary="m7toOXKSSeKRxJh3795HIr3WKhb5gQa1i"; protected-headers="v1" From: Mathieu Arnold <mat@freebsd.org> To: marino@freebsd.org, =?UTF-8?B?UGF3ZcWCIFDEmWthbGE=?= <pawel@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <985bc855-dbed-bd5f-bc2b-d5df6e251890@mat.cc> Subject: Re: svn commit: r420924 - head/audio/gmpc-magnatune References: <201608261504.u7QF46B1060800@repo.freebsd.org> <074eb0ed-40bb-e188-4754-3edde192db12@marino.st> <8fe3e649-e929-c037-6193-c23b685a1222@marino.st> <20160830150544.4f57349e@FreeBSD.org> <71f7c7a0-d2f3-9463-f769-0eb499d4701e@marino.st> In-Reply-To: <71f7c7a0-d2f3-9463-f769-0eb499d4701e@marino.st> --m7toOXKSSeKRxJh3795HIr3WKhb5gQa1i Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 30/08/2016 =C3=A0 15:25, John Marino a =C3=A9crit : > On 8/30/2016 08:05, Pawe=C5=82 P=C4=99kala wrote: >> Hi John, >> >> On 2016-08-29 22:20 -0500, John Marino <freebsd.contact@marino.st> >> wrote: >>> On 8/29/2016 22:17, John Marino wrote: >>>> On 8/26/2016 10:04, Pawel Pekala wrote: >>>>> Author: pawel >>>>> Date: Fri Aug 26 15:04:06 2016 >>>>> New Revision: 420924 >>>>> URL: https://svnweb.freebsd.org/changeset/ports/420924 >>>>> >>>>> Log: >>>>> - Convert to USES=3Dsqlite >>>>> - Convert to PLIST_FILES, only 2 items in plist >>>>> - Register proxy dependencies found by stage-qa >>>>> >>>>> Deleted: >>>>> head/audio/gmpc-magnatune/pkg-plist >>>>> Modified: >>>>> head/audio/gmpc-magnatune/Makefile >>>>> >>>>> Modified: head/audio/gmpc-magnatune/Makefile >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>> >>>>> >>>>> --- head/audio/gmpc-magnatune/Makefile Fri Aug 26 14:58:33 2016 >>>>> (r420923) >>>>> +++ head/audio/gmpc-magnatune/Makefile Fri Aug 26 15:04:06 2016 >>>>> (r420924) >>>>> @@ -14,13 +14,17 @@ LICENSE=3D GPLv2+ >>>>> LICENSE_FILE=3D ${WRKSRC}/COPYING >>>>> >>>>> LIB_DEPENDS=3D libmpd.so:audio/libmpd \ >>>>> - libsqlite3.so:databases/sqlite3 >>>>> + libfreetype.so:print/freetype2 \ >>>>> + libfontconfig.so:x11-fonts/fontconfig >>>>> BUILD_DEPENDS=3D ${LOCALBASE}/libdata/pkgconfig/gmpc.pc:audio/g= mpc >>>>> RUN_DEPENDS=3D gmpc:audio/gmpc >>>>> >>>>> +USES=3D gettext gmake libtool pkgconfig sqlite >>>>> +USE_GNOME=3D cairo gdkpixbuf2 glib20 gtk20 intltool libglade2 >>>>> GNU_CONFIGURE=3D yes >>>>> -USE_GNOME=3D intltool glib20 gtk20 libglade2 >>>>> -USES=3D gettext gmake libtool pkgconfig >>>>> INSTALL_TARGET=3D install-strip >>>>> >>>>> +PLIST_FILES=3D lib/gmpc/plugins/magnatuneplugin.so \ >>>>> + share/gmpc/plugins/magnatune/magnatune.png >>>>> + >>>>> .include <bsd.port.mk> >>>>> >>>> >>>> Pawel, >>>> Many library dependencies were added. That requires a PORTREVISION >>>> bump! >>> >>> actually, I meant to write this about audio/gmpc but it appears >>> audio/gmpc-magnatune had the same issue. >> >> Dependencies added in both ports showed up in poudriere logs so they >> are be definition proxy. So my commits register that this packages lin= k >> to particular libraries, no new dependencies are added - they are >> already pulled in by packages needed to build port. >> >> I do check for new dependencies by comparing poudriere vs live >> build stage-qa outputs to find new ones, but it's not the case here. >> > > I do not believe your method is valid. > If you use pkg(8) to check the dependencies before and after a change > and there's not difference, no bump is needed. > > However, you're relying on dependencies to pull in other dependencies > to say it's equivalent. > > Please check with mat@, he should confirm. > Your method will cause poudriere and other builders to skip updating > the port because it wasn't bumped. > > When in doubt, please bump. It's better to bump unnecessarily than to > not bump when it's required. When adding proxied dependencies, please, always bump PORTREVISION if you are not changing PORTVERSION. The goal of this qa check is to make sure the package really depends on what it needs. If you don't bump PORTREVISION, no new package is built with the correct dependency list, and it is bad. --=20 Mathieu Arnold --m7toOXKSSeKRxJh3795HIr3WKhb5gQa1i-- --lr8ddm2Pnd20J1D06HawB3aqX7wgPm2nQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJXxZXYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IHG4P/2W8RJ/GgFZRHul45rvaCpK5 6QQdycv88bCWNI6nPxELaGa3l9+eyJwDcdUQzbUP2wL9hmwOf2Ps3U4fozvA4SGG 5gWtfjB74z52Pr3OQMyu0OEqv5cWL5b9kI+QepEdvrgBL/a98pxGPyp6yZ9DxO5j CKk4648icBuUxfF18UAIFTmz1PKgoGUYMRrSuzbGBydJrCrB1zZdfBbGQchzqx+L VWMgxWs1/MssvMmJIqFmQtYiOhNVSLxgLy8KQDgsnc4fCVyB4HmuD4VU1DDH4Mzz CzDQ+YyaXCBshTTsk28iWDoG48l0aof1BI44jcaDPxh8xU7bYskudS3ZBjVubZY7 G03x/n/Yom0VY2n0mElr1HVLIVCwjA5oUZKhGry1lOM8/9pzhI9HoK8T+nGT6lE2 rfk28ZBi5DFg1pv1IA1suP25zmWoxKjjrAYfXcGAiVp7+aeysLq2qQ996gerbzK5 OUwSrKoRvY2RMt5LbLjEifva5IoWm738zUmzyMOo5ajM/3Wo5MrUzOj9vm+qT5cK lqWwK6mJK7Kwf/4ziiBQso2+xJoPugbm4bBhExgLVfHIHNhZBBc+eBSRkDk6bQOt Big8HSixPWzKm2laqg0dWyN6tB0f4AwNoO/rL8eUVle/r2ik+RSZ9aY5iopTpmsb ovRHu1ZyFkjBIkCxbSa4 =Eiev -----END PGP SIGNATURE----- --lr8ddm2Pnd20J1D06HawB3aqX7wgPm2nQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?985bc855-dbed-bd5f-bc2b-d5df6e251890>