From owner-freebsd-ports@FreeBSD.ORG  Thu May 24 06:09:26 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BB65F1065680
	for <freebsd-ports@FreeBSD.org>; Thu, 24 May 2012 06:09:26 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 03F678FC1A
	for <freebsd-ports@FreeBSD.org>; Thu, 24 May 2012 06:09:25 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA01138;
	Thu, 24 May 2012 09:09:19 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SXREc-0005Zw-SB; Thu, 24 May 2012 09:09:18 +0300
Message-ID: <4FBDD08B.2000801@FreeBSD.org>
Date: Thu, 24 May 2012 09:09:15 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120503 Thunderbird/12.0.1
MIME-Version: 1.0
To: Gerald Pfeifer <gerald@pfeifer.com>
References: <CAGFTUwPUFdP=Z20+bL59qFuh_V6R1R-GcyrK03dxESL6ZyGz7A@mail.gmail.com>
	<4F578AA7.4060008@FreeBSD.org> <4F990D9A.3090100@FreeBSD.org>
	<4FA643FA.3050206@FreeBSD.org> <4FAB6E01.50108@FreeBSD.org>
	<4FAC3084.80101@FreeBSD.org>
	<alpine.LNX.2.00.1205160324510.2599@zbenl.fvgr>
	<4FB34182.20605@FreeBSD.org>
	<alpine.LNX.2.00.1205210751180.6769@zbenl.fvgr>
In-Reply-To: <alpine.LNX.2.00.1205210751180.6769@zbenl.fvgr>
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Mark Linimon <linimon@lonesome.com>, freebsd-ports@FreeBSD.org
Subject: Re: WITH_GCC
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2012 06:09:26 -0000

on 21/05/2012 05:54 Gerald Pfeifer said the following:
> On Wed, 16 May 2012, Andriy Gapon wrote:
>>>> +CFLAGS+=		${CFLAGS.${CC}}
>>>> +CXXFLAGS+=		${CXXFLAGS.${CC}}
>>>
>>> Similarly here.  Where does this come from, why is it related to
>>> the WITH_GCC versus USE_GCC patch?  Can and should this be split
>>> out?  How is it used and where?  Where is it defined?
>>
>> This should be split out.  The use case is to make it possible to set 
>> something like the following in make.conf:
>>
>> CFLAGS.gcc46+= -fearlier-gcc-fails-with-this-flag-but-I-want-it-with-gcc46
> 
> I see!  The only question I have is whether, given there is also clang, 
> this is really best suited for Mk/bsd.gcc.mk, or this should rather
> become part of the general Mk/bsd.port.mk?

I think so.  My patch was intended to handle only different GCC versions, I made
it for my personal use :-)
Mark's patch on the other hand does a job of supporting different compilers too.

> To me it looks more like the latter, Mk/bsd.port.mk, but if not for
> some reason, please add a comment to the top of the file Mk/bsd.gcc.mk
> and commit this part.

No, no, thank you :-)

-- 
Andriy Gapon