From nobody Mon Aug 7 22:45:43 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKWcl67Fgz4mT3F; Mon, 7 Aug 2023 22:45:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKWcl4Qtxz4Nvr; Mon, 7 Aug 2023 22:45:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mzsLtFYMF5dwhSC9J4PfStSOe8uMCaiX0ymBEicAU9M=; b=NGGC3I6II/gt3EuBqgwFsWKc1ERZceqwS9s92eHNNwXWUTJetah9+LFmckCuozf7hJK6CJ LSFQvNMdZIR3jBY1UVbjQsubIlEFOWxwKo3ToG+rQyYNiCr2PFCwqn18eig3y8GEtO5lD3 TH9dFHABdDJv7OxmGtMMVD17cbF+iEhJMzb4yYSa4ZwG1hi5LHL2ZRRh8IWG6yOkvIJ02I 56bGnLl2PJUt4CmWKRJOyKcYLysm5G8TVtA4dAhURVTxPAbT+2qE5Cl4MGYK31j75AQYEa ELx4J8cIIElyjgwXpbyl8cSMQJKlEuGAn69rwH+6tifoEMRiNmO2hAhc8L6Vfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mzsLtFYMF5dwhSC9J4PfStSOe8uMCaiX0ymBEicAU9M=; b=Y+8aiZLjSjthnxMPoifDiXPK18EEJz0PsFgxKjN8zhLezpyoQYbc6DQczuG0x6G3R/rXyz BQQizM9Qi3gdr1ndpEN/6MCZ44qfWyFEiPPa12Am39+39pMaaDkeh2Zkh0vDEjPBGat0UI X3MktgYMv4r0DIRleGxWn+yRQlvZZUAkDAZBSHmKFAWiXAwA9zlpCBsYOzBBxSYtfLq26G CqP15PwKcn/jPcjRYZYWhGXC/N6g0kJb72dkha/0Z8BmCHQGswhQEIwgyLKALeG8ry24yo Cd8xjCub/u2Qf8NJNFm6Z73C8O28K5De+lbYHIiNIyhfwREFAOKEycndx7Iw9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691448343; a=rsa-sha256; cv=none; b=eooOJ++/KUqVdG7Yot4pUBIviKAsYbmZBgpL6TVbNHE330/i/VAGKkuhdj6tF0GDubszah 8p+f9TXG+tO/gO8hfgJzrzRkuzp2WAKVghrbwL5HTawXj/eFjmPphjPCaGq5PWnIG9Gf7S aHkC2WlX4DM1p6vgO6SfoXtAMZsgqrKdj9SwZ+XZ9CriU+aUYEB2oDgT1FwTqNgmaADbG8 mNzGwkjOJyPjHrdTZxiqrvdIT7i3NMysZhIRMaQNkXIhoX0JvuUIN7A4LQpsPTSuYRRL6W iN7MKRDq2k0dvouJM76gA5nSpwEis29fC/iLh97VRr7Gewj/53+xSLK8vsDLyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RKWcl3Xwxz195k; Mon, 7 Aug 2023 22:45:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 377MjhLZ058695; Mon, 7 Aug 2023 22:45:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 377Mjh6j058694; Mon, 7 Aug 2023 22:45:43 GMT (envelope-from git) Date: Mon, 7 Aug 2023 22:45:43 GMT Message-Id: <202308072245.377Mjh6j058694@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 95cd10f13971 - main - nvme: Add comments about other fields in status List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 95cd10f13971ef2f035f07c9bda14fb094edc0b3 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=95cd10f13971ef2f035f07c9bda14fb094edc0b3 commit 95cd10f13971ef2f035f07c9bda14fb094edc0b3 Author: Warner Losh AuthorDate: 2023-08-07 22:36:14 +0000 Commit: Warner Losh CommitDate: 2023-08-07 22:44:31 +0000 nvme: Add comments about other fields in status When manually completing an I/O, we do so because we have no status back from the card. Note M, CRD and P are all 0 because this is an artificial event (and phase isn't checked when it's completed this way). There's no MORE information in the error log page and there's no delayed retry (CRD=0) and we don't currently request CRD to be set to anything other than 0 and thus don't implement delayed retry. Sponsored by: Netflix Reviewed by: chuck, mav, jhb Differential Revision: https://reviews.freebsd.org/D41314 --- sys/dev/nvme/nvme_qpair.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/nvme/nvme_qpair.c b/sys/dev/nvme/nvme_qpair.c index 0a0115967eef..878df6183eea 100644 --- a/sys/dev/nvme/nvme_qpair.c +++ b/sys/dev/nvme/nvme_qpair.c @@ -503,6 +503,9 @@ nvme_qpair_manual_complete_tracker( cpl.status |= (sct & NVME_STATUS_SCT_MASK) << NVME_STATUS_SCT_SHIFT; cpl.status |= (sc & NVME_STATUS_SC_MASK) << NVME_STATUS_SC_SHIFT; cpl.status |= (dnr & NVME_STATUS_DNR_MASK) << NVME_STATUS_DNR_SHIFT; + /* M=0 : this is artificial so no data in error log page */ + /* CRD=0 : this is artificial and no delayed retry support anyway */ + /* P=0 : phase not checked */ nvme_qpair_complete_tracker(tr, &cpl, print_on_error); }