From owner-cvs-all@FreeBSD.ORG Tue Sep 12 07:28:00 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C023D16A417; Tue, 12 Sep 2006 07:28:00 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A722243D68; Tue, 12 Sep 2006 07:27:56 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k8C7RrOZ007465; Tue, 12 Sep 2006 11:27:53 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k8C7RrWq007464; Tue, 12 Sep 2006 11:27:53 +0400 (MSD) (envelope-from yar) Date: Tue, 12 Sep 2006 11:27:53 +0400 From: Yar Tikhiy To: gnn@freebsd.org Message-ID: <20060912072753.GA6809@comp.chem.msu.su> References: <200609081309.k88D9GCQ077401@repoman.freebsd.org> <20060908100034.M18039@odysseus.silby.com> <20060908154824.GK40020@FreeBSD.org> <20060911003357.V23530@odysseus.silby.com> <20060911142826.GG27667@FreeBSD.org> <20060911223812.GA1439@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Mike Silbersack , cvs-all@freebsd.org, Gleb Smirnoff , Ruslan Ermilov Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 07:28:00 -0000 On Tue, Sep 12, 2006 at 11:25:18AM +0900, gnn@freebsd.org wrote: > At Tue, 12 Sep 2006 02:38:13 +0400, > Yar Tikhiy wrote: > > > > On Mon, Sep 11, 2006 at 06:28:26PM +0400, Gleb Smirnoff wrote: > > > On Mon, Sep 11, 2006 at 12:36:57AM -0500, Mike Silbersack wrote: > > > M> >It stops creating any state (nor socket neither compressed tcptw) for the > > > M> >TCP connection, where both endpoints were local. This save a lot of > > > M> >resources on servers running HTTP accelerators, or database > > > M> >servers+clients. > > > M> > > > M> I think that you should change the description to say "Do not create TCP > > > M> TIME_WAIT entries for local <-> local connections" (or something similar) > > > M> to remove the ambiguity, and turn it on by default for 7. This seems like > > > M> a good idea, I'm jealous that I didn't think of it. :) > > > > > > OOh, the sysctl name and its description were discussed with ru@, who > > > is our famous nitpicker. If you want to change name or description - > > > mail to him. /me hides > > > > (It was me who suggested a different name for the sysctl in question.) > > > > IMHO it's time to define a general style for new sysctl names. > > The first two points could be a) "foo" vs. "nofoo" for boolean > > knobs, and b) underscore usage. > > > > Presently there seem to be few "nofoo" knobs in the system, e.g.: > > > > # sysctl -aN | fgrep .no > > kern.nodump_coredump -- should be coredump_nodump > > net.inet6.icmp6.nodeinfo -- false match > > debug.nosleepwithlocks > > dev.fxp.0.noflow > > > > I don't think new ones should be introduced; their logic would be > > unnecessarily vague. > > > > OTOH, there are enough sysctl names containing an underscore to > > encourage using it in complex names. An exception could be made > > for really short names, such as consisting of not more than 2 words, > > each being not longer than 4 letters. > > > > What do you think about that, folks? > > I am for it, in particular if it is documented. Of course, it should be documented. However, I'm not certain yet where the text belongs to. Could it be in the sysctl(9) manpage? -- Yar