From owner-freebsd-hackers Sat Sep 29 13:34:36 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id EA82837B405 for ; Sat, 29 Sep 2001 13:34:33 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id DE8D981D0B; Sat, 29 Sep 2001 15:34:33 -0500 (CDT) Date: Sat, 29 Sep 2001 15:34:33 -0500 From: Alfred Perlstein To: Toshihiko ARAI Cc: freebsd-hackers@FreeBSD.org Subject: Re: Doubt of system(3) Message-ID: <20010929153433.U59854@elvis.mu.org> References: <200109291527.f8TFRrU76727.toshi@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200109291527.f8TFRrU76727.toshi@jp.FreeBSD.org>; from toshi@jp.FreeBSD.org on Sun, Sep 30, 2001 at 12:27:54AM +0900 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Toshihiko ARAI [010929 11:10] wrote: > I consider the following code of system(3). pid is changed by return > value of _wait4(). I feel this need a correction. > > default: /* parent */ > do { > pid = _wait4(pid, &pstat, 0, (struct rusage *)0); > } while (pid == -1 && errno == EINTR); > break; > > Please review and commit this patch. Why does it need to be corrected? What sort of bad behaviour are you seeing? You do 'a' and you see 'b' when you should see 'c'. What's a, b and c? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message