From nobody Tue Sep 16 11:24:49 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cR01F5qJLz68nmn; Tue, 16 Sep 2025 11:24:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cR01F5H0lz46hG; Tue, 16 Sep 2025 11:24:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758021889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TN1AvspHK7Jl0yfO4vns70pbURgOvEBoJvzRd1sTnUg=; b=BYXmoKFz9/x9kByOXllyqgwLElncASCIypKkEaDbYJoM3uSZcncYFdeA+KTI6b+iPYZKn7 skhHdLxJD77oP/tllw9M5IWsJRl08wiTj3Jb0pnTLNGdPq0f0BzK/oyY4UdzxwVO4XGsy0 wfP0cTLBHXOGsZ9lSzQx8sfSqexELG5xqSZxygqLYol1mcm0yhUkR3+IPeCb3pKj6fAo0j /Z02G7QKacfWxUQmwCYPY/0rjg+2gWDMzw18wTb96nGQ4jadHkMtcqu6B4bHcKvd4u5/Oy i62sbY+OefjC52kW9WUQxq95J4F493rtA4BdcHV2QL+GfsWD6LUpRKnHEAXL+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758021889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TN1AvspHK7Jl0yfO4vns70pbURgOvEBoJvzRd1sTnUg=; b=IaNwVlArFDneMBvD+eWLudYREPf484JTmxPDooxZzG/rBmnUyAa6TUZjFYi1zX3O5Jaytq nM4I94ZhlLmSIXF3HfNYoRFm2cJgzORqhLTEWU8LLcVqdgdsBKSgxiiTz5HajRMw75QgLC hajWzxfm4UcF82L1z6xLzr4kwWxl+mxdbxy6+worrB8RImnrNMJASsa2Ap08iY2zkHsHhd yyNriupKVFfhFqgsCqfQTVjzMHbIT98d8xz1SLbO5LXuB7r4iM9W3gm/OpDdnKbZ1b8/27 cBlz1snBB4rnbXgWn6gpVrd9I4x/WyN/ss00hYL31sseckLw7X8ta4a6boZSdg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758021889; a=rsa-sha256; cv=none; b=QMCyvlHa1QFMZZHFnCOFKLUBw25yR14JmR4dWxMhGoLdId8jp48IRHEOY7OltNWVaJvzjd B2mBT6dhFAHSddJaOWY7QWwcU3sRGYJKAbJNRca4fWralZNyRX/y7M1ho4gAC+9ngz0fKg frKPI1QgUm28DGjagPXGq2JlCfszwko8TaKUVVLGaAG0qIlrMuLAWc86CHSADDlWHJMtGF 3oYxQtr4Ve8uJ/nWE0xiEnnYTlwb5Ou51JeBDnoTLukIH5/HkG8QWAQHrYyrxnNBLS6ls1 8tUVdLlxdQYpdNd4n65wr9SnJu58z6+THIn/kU8tNt0ioasyDNhA6DR9xLLjoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cR01F4bthzfSK; Tue, 16 Sep 2025 11:24:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58GBOneB079942; Tue, 16 Sep 2025 11:24:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58GBOnSx079939; Tue, 16 Sep 2025 11:24:49 GMT (envelope-from git) Date: Tue, 16 Sep 2025 11:24:49 GMT Message-Id: <202509161124.58GBOnSx079939@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 7314f78b240b - main - aarch64: Clarify the initial adjustments to sp for kernel exception entry List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7314f78b240bdbf2bcec07e3d5a475e37941bb6b Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=7314f78b240bdbf2bcec07e3d5a475e37941bb6b commit 7314f78b240bdbf2bcec07e3d5a475e37941bb6b Author: John Baldwin AuthorDate: 2025-09-16 11:21:39 +0000 Commit: John Baldwin CommitDate: 2025-09-16 11:21:39 +0000 aarch64: Clarify the initial adjustments to sp for kernel exception entry The first store-pair instruction in save_registers_head decrements the stack pointer to create room for most of the trapframe (and the redzone area for nested exceptions). However, the expression was a bit non-intuitive as it was using an expression without a leading negative sign to adjust the stack pointer. Rewrite the expression so that it is more clearly a negative adjustment to the stack pointer. Suggested by: andrew Reviewed by: andrew Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D52514 --- sys/arm64/arm64/exception.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm64/arm64/exception.S b/sys/arm64/arm64/exception.S index 13095def8b00..6e673fbe5a43 100644 --- a/sys/arm64/arm64/exception.S +++ b/sys/arm64/arm64/exception.S @@ -43,9 +43,9 @@ .macro save_registers_head el .if \el == 1 mov x18, sp - stp x0, x1, [sp, #(TF_X - TF_SIZE - 128)]! + stp x0, x1, [sp, #-(TF_SIZE - TF_X + 128)]! .else - stp x0, x1, [sp, #(TF_X - TF_SIZE)]! + stp x0, x1, [sp, #-(TF_SIZE - TF_X)]! .endif stp x2, x3, [sp, #(2 * 8)] stp x4, x5, [sp, #(4 * 8)]