From nobody Wed Aug 5 15:16:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsJ3XG4z6nQ5r for ; Wed, 05 Aug 2026 15:16:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYsJ144sz3vTr for ; Wed, 05 Aug 2026 15:16:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785942980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kN04cZw8fiyvIowW5X5HGkx4H9TIG5U60uJNULL3l10=; b=MosPgGGKvwAGwjzVBsDxrgtd3olC3US6GHbZ0MRUrc6efVxbKuhLlvTNevBeQUWXX5B7sA lJELK+kIS74DdnneMwJ+IOoLI3NFFYDLHTtngot37r0DKwYhRjUQAW9E64ABWDcveRxVEl n1uBicurxTQlfaomQfmN+7QSqF8R+WJLdcjOGHu96SchasTZXmGmNNVSGsf3co2rjr2wo1 OKR0DzaQHmPw/EHAL09z4ljV0kDuoiLHcw0mTb/x/pfPcX0Q0o2DTQL/Ao7ux/rHiKxxUB q1rZV/0KzeBxUIBad7quMg7T9/odnbZksz/NRq2Nz526CpTay9/iEGX2jm1+gg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785942980; a=rsa-sha256; cv=none; b=YMzES1y7d85C1Wr2dcq3dBGJfvAZtHgoK2ucfREoxKlQzwnA77epyiVgNdG/8E2J9PLMYU xsY9HR91RjVemwXlxPJ5Ohw0o7METaiooCFm3qy5r8hFLE1ELRbuhJ+5gn+nWKP5AitX59 F16wOzdVldSTHOeBkl4DDzr9kSJIpu3Ha1wlSStmQwZmNdOwEr2st+QadnJSE2bW1GgWD5 Lh7NZxJZU0M7TrpblxGWfQcpwEPyeHERmrpy+JDRxL45m+5YPWtM1uOfQzOOzP7Fg1TqQB VkOxhCdC9/9l2Bb8TAzp8m9shwQpDeUDiqilhnLX+UL47V4YYa1BtqWSyg/RoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785942980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kN04cZw8fiyvIowW5X5HGkx4H9TIG5U60uJNULL3l10=; b=dE9hiAJOTopDRp7WJE35XowKY5O8GtR86G+KuZwn1cvCYdp8E/v7upegoJgJuJDSR9a+lG uFSfbAWemznrZuRLh1GqRjjdFly8kvG7sw4/jN00rhvHdrwWMHcrCLDT2JXibw4LNs+BCg 0YEYlkaybs6MmcIq0Yg60WdQgz9FXXYZTPPVGKCYZBDV0I5aCG/6jdxPvkUBOMJnuka0kx LuQh3ndpBMZHuRNmHEJBlschnfdu+WW958uSI5re0N3SB0o3WYGsRIdA7zslZm/yzhaOlY 3BeQvReWk2Cd1/S1Edr/4SE52kP9j7R8qBDk1zfZmeffFbI/gha2YalgSW5nXg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsH6tcTzg7V for ; Wed, 05 Aug 2026 15:16:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 466d2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:16:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 011c5e68c95c - stable/14 - ipsec: Fix a lock leak in ipsec_chkreplay() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 011c5e68c95c8ec74b272dd2f2680fb6c6aa7dde Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:16:19 +0000 Message-Id: <6a7353c3.466d2.120b8b1c@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=011c5e68c95c8ec74b272dd2f2680fb6c6aa7dde commit 011c5e68c95c8ec74b272dd2f2680fb6c6aa7dde Author: Mark Johnston AuthorDate: 2026-07-29 13:19:08 +0000 Commit: Mark Johnston CommitDate: 2026-08-05 15:15:14 +0000 ipsec: Fix a lock leak in ipsec_chkreplay() Reported by: Chris Jarrett-Davies of the OpenAI Codex Security Team Reviewed by: pouria, kp Fixes: 0361f165f219 ("ipsec: replace SECASVAR mtx by rmlock") MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58521 (cherry picked from commit b6823a973737f06ea6cf0ea5a3083383af2ba5a4) --- sys/netipsec/ipsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netipsec/ipsec.c b/sys/netipsec/ipsec.c index 0ca33424bca8..e7a816f98d45 100644 --- a/sys/netipsec/ipsec.c +++ b/sys/netipsec/ipsec.c @@ -1330,8 +1330,10 @@ ipsec_chkreplay(uint32_t seq, uint32_t *seqhigh, struct secasvar *sav) * subspace. */ if (tl < window - 1 && seq >= bl) { - if (th == 0) + if (th == 0) { + SECREPLAY_UNLOCK(replay); return (0); + } *seqhigh = th - 1; seqh = th - 1; if (check_window(replay, seq)) {