From owner-svn-src-head@FreeBSD.ORG Wed Jan 28 16:35:11 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94185A01; Wed, 28 Jan 2015 16:35:11 +0000 (UTC) Received: from smtp4.ore.mailhop.org (smtp4.ore.mailhop.org [54.149.240.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 736C8B43; Wed, 28 Jan 2015 16:35:11 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp4.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YGVa4-0002ho-Ub; Wed, 28 Jan 2015 16:35:05 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t0SGZ3WS025558; Wed, 28 Jan 2015 09:35:03 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1/wRkuSZJsKZwQWbFbPv9q5 Message-ID: <1422462903.15718.60.camel@freebsd.org> Subject: Re: svn commit: r277835 - in head: lib/libpmc sys/arm/arm sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys From: Ian Lepore To: Ruslan Bukin Date: Wed, 28 Jan 2015 09:35:03 -0700 In-Reply-To: <201501281608.t0SG88gs009253@svn.freebsd.org> References: <201501281608.t0SG88gs009253@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 16:35:11 -0000 On Wed, 2015-01-28 at 16:08 +0000, Ruslan Bukin wrote: > Author: br > Date: Wed Jan 28 16:08:07 2015 > New Revision: 277835 > URL: https://svnweb.freebsd.org/changeset/base/277835 > > Log: > Add ARMv7 performance monitoring counters. > > Differential Revision: https://reviews.freebsd.org/D1687 > Reviewed by: rpaulo > Sponsored by: DARPA, AFRL > > Added: > head/sys/dev/hwpmc/hwpmc_armv7.c (contents, props changed) > head/sys/dev/hwpmc/hwpmc_armv7.h (contents, props changed) > Modified: > head/lib/libpmc/libpmc.c > head/sys/arm/arm/intr.c > head/sys/arm/include/pmc_mdep.h > head/sys/arm/ti/files.ti > head/sys/conf/files.arm > head/sys/dev/hwpmc/hwpmc_arm.c > head/sys/dev/hwpmc/pmc_events.h > head/sys/sys/pmc.h This was in phabricator for review for 27 hours before it got committed, that's not enough time to allow people to actually review it. That would be not enough time for even a simple change, let alone over a thousand of lines of code. It certainly wasn't reviewed by those actively working on arm pmc stuff recently (gnn and to a lesser degree, me). Just from a quick glance at the part that wasn't truncated, I notice all the inline asm stuff is wrong -- it duplicates what's already available in cpu-v6.h. -- Ian