From owner-freebsd-libh Sun Jun 2 22:25:11 2002 Delivered-To: freebsd-libh@freebsd.org Received: from tomts22-srv.bellnexxia.net (tomts22.bellnexxia.net [209.226.175.184]) by hub.freebsd.org (Postfix) with ESMTP id AEA9837B401 for ; Sun, 2 Jun 2002 22:25:07 -0700 (PDT) Received: from shall.anarcat.ath.cx ([65.94.145.70]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20020603052506.QCDV25645.tomts22-srv.bellnexxia.net@shall.anarcat.ath.cx> for ; Mon, 3 Jun 2002 01:25:06 -0400 Received: from lenny.anarcat.ath.cx (lenny.anarcat.ath.cx [192.168.0.4]) by shall.anarcat.ath.cx (Postfix) with SMTP id ED6B45 for ; Mon, 3 Jun 2002 01:28:49 -0400 (EDT) Received: by lenny.anarcat.ath.cx (sSMTP sendmail emulation); Mon, 3 Jun 2002 01:23:26 -0400 Date: Mon, 3 Jun 2002 01:23:26 -0400 From: The Anarcat To: libh@FreeBSD.org Subject: Re: cvs commit: libh/lib/sysinstall Database.cc Message-ID: <20020603052326.GL288@lenny.anarcat.ath.cx> References: <20020603052313.592AF17407@usw4.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wAI/bQb0EMvlZCHl" Content-Disposition: inline In-Reply-To: <20020603052313.592AF17407@usw4.freebsd.org> User-Agent: Mutt/1.3.99i Sender: owner-freebsd-libh@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --wAI/bQb0EMvlZCHl Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'll try to setup a regression test to forbid this to happen again. A. On Mon Jun 03, 2002 at 12:23:13AM -0500, Antoine Beaupr=E9 wrote: > antoine 2002/06/03 00:23:13 CDT >=20 > Modified files: > lib/sysinstall Database.cc=20 > Log: > read directory access info from database before inserting SYSTEM > package in order to have insert_denied_allowed_directories() Do The > Right thing > =20 > this fixes a bug where allowed access list was reset to a hardcoded > default each time the database was open > =20 > note, while I'm here, that there shouldn't be such a hardcoded value > in there > =20 > the existence and use of insert_denied_allowed_directories() is also > debatable. It should at least readDirectoriesAccess instead of relying > on it to be called by the consumer > =20 > Revision Changes Path > 1.7 +4 -4 libh/lib/sysinstall/Database.cc >=20 >=20 > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-libh" in the body of the message --=20 The idea that Bill Gates has appeared like a knight in shining armour to lead all customers out of a mire of technological chaos neatly ignores the fact that it was he who, by peddling second-rate technology, led them into it in the first place. - Douglas Adams (1952-2001) --wAI/bQb0EMvlZCHl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE8+v1NttcWHAnWiGcRAvL4AKCM3CSl4g6gOCvFKDvj7L+89pfd5gCffi5o mpXPSpnrXqdoCm0k2mDoBZA= =kUWE -----END PGP SIGNATURE----- --wAI/bQb0EMvlZCHl-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-libh" in the body of the message