From nobody Mon Dec 15 18:18:26 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dVSwy4kJDz6L7L7 for ; Mon, 15 Dec 2025 18:18:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dVSwy2G14z4Krw for ; Mon, 15 Dec 2025 18:18:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765822706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LImktDrvshb2v6QN9V4x545girzGWYlHSKZzUgFnlKU=; b=Bu1ZigbQHjLxTqDAtb5YFuNivh8IEHL6xM0i3vguo3obQ6q7ssYS6rBuSqLEVKi/u3YBSR IGkVpxOoqHcRbj2bXkr8EOD11fiWTXB2rY31wXijGq0gmVy0Kp2fzR+KCS85wk2GbTXpUJ S3X1KgHP5aZTezwxZkSvbPTkQhDh6YE4LS68Cns6RtKnMG14LUQ+3YeccTcFRwp4aKoFZO Qec68olxBJMDDm2pAR3GOjETnRJYFWDrodJAPC4pAlhlTouYF1jRCk0VxThkZQt5y5hyzZ zej/czKI92Qmje0IKQYQem9kzRGrVoZro1igGlvqRaiNQQuP2HqeONj27d+gUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765822706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LImktDrvshb2v6QN9V4x545girzGWYlHSKZzUgFnlKU=; b=W9BE6n89ysBh5u33HscuSI49t9GBX/fOWyOA9cLAbhJtPwRLodvV6lrROtDZiQ8xdYZB77 kt+/+avU2mSf4xMjEJuIFyXg/mKRljMAJ/vf4xavJG1RSHleBcUR42UawOue/kJaqkdyLf nubq1YSP61PrBvTPCwgIJ0r938z+o8nB42bhDtS1PmxvR49DnZJOSHSBMktpzlXiRMaicN CaM//kDUoiz/OBZA3B0UHf8iwW0wBIaGPimKQo6Hsv3Ju31ZP0fA2GmO+1lLL1bx+lxqgf f369k7IqZVactS6zza7hvZkiF+jSar0JFSlFKsthgZQnIDmY+xPfdE4Rih09Iw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765822706; a=rsa-sha256; cv=none; b=mfd1rNi7eHue4B4ry0vKIeaGoc6jlafhkQNjOFD3iob5u5ylZWpOByH7kyHahIiZUNvg1T Yp94RIGRhcfs27s2b79cUZ4u3JNV7fAZU/I2j9/PlrVKyjvqZSo/DVxQZAmGm5OvawUeWY mRCFxWpGeEHXl75+txG2svTcZPnUb0Hy2PJnpDYswGdHS7qsPU4nkMX+DfutVqw3Qf0uT9 2zEJKO82UKDGRqI2k25iv6CkblGjiUSUHGc0kZOmJWRtq7xXbljKxmgQF+jy+D2hCm7Ipg jWLzaS6IbX9d0pk+smSk+1X3v5ryBAg48VuX3EuXFu35dxiRShjNPkjduS8eXA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dVSwy1hnWzW0k for ; Mon, 15 Dec 2025 18:18:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 257f5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Dec 2025 18:18:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jessica Clarke Subject: git: 8aaae40a354a - stable/13 - ee: Fix use of uninitialised pointer in ispell_op List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8aaae40a354a831b0c2ac13f34dbf0f99faa8b8b Auto-Submitted: auto-generated Date: Mon, 15 Dec 2025 18:18:26 +0000 Message-Id: <694050f2.257f5.25b0b3df@gitrepo.freebsd.org> The branch stable/13 has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=8aaae40a354a831b0c2ac13f34dbf0f99faa8b8b commit 8aaae40a354a831b0c2ac13f34dbf0f99faa8b8b Author: Jessica Clarke AuthorDate: 2024-06-02 22:53:09 +0000 Commit: Jessica Clarke CommitDate: 2025-12-15 17:56:34 +0000 ee: Fix use of uninitialised pointer in ispell_op This used to be name = mktemp followed by fd = open downstream, replacing upstream's crude PID-based sprintf, but in 1.4.7 this was changed upstream to this buggy code, which we then picked up in the 1.5.0 import. Presumably nobody's actually used ee's ispell function in the past 15 years; that or it's just ended up using junk file names as temporary files if name's happened to be a valid address to something that can be interpreted as a string. Reported by: Dapeng Gao Fixes: 96b676e99984 ("Update ee(1) in the base system to version 1.5.0.") MFC after: 1 week (cherry picked from commit 25a33bfe9ce2b55812201f475e9d3e64009b40dc) --- contrib/ee/ee.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/ee/ee.c b/contrib/ee/ee.c index 5976152414cb..002852e9e59a 100644 --- a/contrib/ee/ee.c +++ b/contrib/ee/ee.c @@ -4436,6 +4436,7 @@ ispell_op() } (void)sprintf(template, "/tmp/ee.XXXXXXXX"); fd = mkstemp(template); + name = template; if (fd < 0) { wmove(com_win, 0, 0); wprintw(com_win, create_file_fail_msg, name);